Skip to content

[Refactor]: Migrate stderr logs to structured events - #115

Merged
viiccwen merged 1 commit into
mainfrom
refactor/remove-eprint
Jul 18, 2026
Merged

[Refactor]: Migrate stderr logs to structured events#115
viiccwen merged 1 commit into
mainfrom
refactor/remove-eprint

Conversation

@viiccwen

Copy link
Copy Markdown
Contributor

Summary

Replace the remaining unstructured stderr diagnostics with sanitized lifecycle events while preserving MCP stdio protocol safety. Remove the now-unused console helper after migrating MCP, webhook, and course catalog logging.

Related Issue

Fixes #114
Follow-up to #91

Type of Change

  • Bug fix
  • New feature
  • Refactor
  • Documentation
  • Configuration or deployment
  • Tests

Changes

  • Migrate MCP tool, startup, member notification, and dependency initialization diagnostics to structured events without raw query or platform identifiers.
  • Migrate webhook startup/callback failures and course catalog cache/fetch/retry events with consistent component, status, duration, and error-type fields.
  • Remove ian.utils.console.eprint and add table-driven privacy, retry-state, callback, and stdio regression tests.

Testing

  • Local tests or checks pass
  • Manual verification completed
  • Not tested; reason:

Commands run:

  • make test — 283 passed
  • make precommit — all hooks passed
  • git diff --check — passed

Impact Checklist

  • Discord bot behavior checked, if affected
  • MCP server behavior checked, if affected
  • Webhook behavior checked, if affected
  • Docker or compose changes checked, if affected
  • Environment variables documented, if changed
  • Logs do not expose secrets or sensitive data

Notes for Reviewers

The MCP regression test verifies that stdio startup emits structured JSON to stderr while leaving stdout empty. Platform integrations are tested with mocked boundaries; no live messages or external requests were sent.

Signed-off-by: viiccwen <vicwen@apache.org>
@viiccwen
viiccwen marked this pull request as ready for review July 18, 2026 12:59
@viiccwen
viiccwen merged commit 0b1763d into main Jul 18, 2026
2 checks passed
@viiccwen
viiccwen deleted the refactor/remove-eprint branch July 18, 2026 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature]: Migrate remaining stderr logs to structured events

1 participant