Skip to content

[Test]: cover notification delivery helpers - #108

Merged
viiccwen merged 1 commit into
mainfrom
test/notification-delivery-helpers
Jul 13, 2026
Merged

[Test]: cover notification delivery helpers#108
viiccwen merged 1 commit into
mainfrom
test/notification-delivery-helpers

Conversation

@viiccwen

Copy link
Copy Markdown
Contributor

Summary

Add deterministic unit coverage for Discord notification delivery helpers and staff notification formatting. All Discord and delay boundaries are mocked, so the suite runs without external API access.

Related Issue

Fixes #85

Type of Change

  • Bug fix
  • New feature
  • Refactor
  • Documentation
  • Configuration or deployment
  • Tests

Changes

  • Add table-driven coverage for member delivery success/failure aggregation and mocked delivery delays.
  • Cover Discord channel success statuses, failure statuses, and exceptions without network calls.
  • Verify logging no-ops without configuration and delegates when configured.
  • Expand staff-role and notification-format coverage for optional fields, recording flags, and long-outline truncation.

Testing

  • Local tests or checks pass: make test (165 passed)
  • Manual verification completed: make precommit and git diff --check
  • Not tested; reason:

Impact Checklist

  • Discord bot behavior checked, if affected
  • MCP server behavior checked, if affected
  • Webhook behavior checked, if affected
  • Docker or compose changes checked, if affected
  • Environment variables documented, if changed
  • Logs do not expose secrets or sensitive data

Notes for Reviewers

This is a test-only change. Discord API functions and time.sleep are mocked, and all member fixtures use synthetic identifiers and addresses.

Signed-off-by: viiccwen <vicwen@apache.org>
@viiccwen
viiccwen marked this pull request as ready for review July 13, 2026 04:42
@viiccwen
viiccwen merged commit 46f798c into main Jul 13, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature]: Add unit tests for notification delivery helpers

1 participant