[Bug]: prevent reminder batch abort on delivery failure - #105
Merged
Conversation
Cover fetch failures, no-event and dry-run exits, and personalized Discord delivery counts without external services. Closes #83 Signed-off-by: viiccwen <vicwen@apache.org>
viiccwen
changed the title
viiccwen
marked this pull request as ready for review
July 12, 2026 15:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prevent the daily reminder batch from aborting when member data cannot be loaded or an individual Discord DM raises an exception. Add focused regression coverage and table-driven boundary cases for reminder behavior.
Related Issue
Fixes #83
Fixes #106
Type of Change
Changes
Testing
Commands run:
External Discord calls remain mocked; no live member notifications were sent.
Impact Checklist
Notes for Reviewers
The change is limited to the daily reminder service and its domain/service tests. A failed recipient is counted as failed, processing continues, and the existing summary log is still emitted.