fix: retrieve cached catalog via Standalone Fetch when content_exists#267
Open
d-matsui wants to merge 8 commits into
Open
fix: retrieve cached catalog via Standalone Fetch when content_exists#267d-matsui wants to merge 8 commits into
d-matsui wants to merge 8 commits into
Conversation
Add encode/decode for FETCH, FETCH_OK, FETCH_HEADER, and fetch object fields. Consolidate into fetch.rs matching the structure of subgroup.rs. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Add is_empty guard in fetch_decoder to prevent spurious error logs - Split catch-all arm into None/Some(Err) in fetch_data_receiver - Add Fetch::End variant for clean stream termination - Add resolve_object_id tests for subgroup Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Add end-to-end example for Standalone Fetch. Alice publishes 3 groups, bob subscribes live then issues fetch A/B/C to retrieve cached objects from the relay. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is ❌ Your patch check has failed because the patch coverage (28.54%) is below the target coverage (70.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## master #267 +/- ##
==========================================
+ Coverage 10.61% 12.31% +1.70%
==========================================
Files 160 173 +13
Lines 8496 9085 +589
==========================================
+ Hits 902 1119 +217
- Misses 7594 7966 +372 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
content_exists=trueand Largest Location from cache in SUBSCRIBE_OKcontent_exists=trueChanges
relay
TrackCache::largest_location()that resolves group_id/object_id by walking the delta chainlargest_location()call app (WASM bindings + TypeScript)
content_exists=truewith a valid largest location,fetch the cached catalog immediately via Standalone Fetch instead of waiting for stream delivery
setOnSubgroupObjectHandlerafter the fetch so subsequent catalog updatesarriving via stream are still handled
Test plan
Tested manually in the call app example: