Skip to content

Extended Range#4094

Open
End-rey wants to merge 4 commits into
masterfrom
extended-range
Open

Extended Range#4094
End-rey wants to merge 4 commits into
masterfrom
extended-range

Conversation

@End-rey

@End-rey End-rey commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

@codecov

codecov Bot commented Jul 16, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 45.36585% with 224 lines in your changes missing coverage. Please review.
✅ Project coverage is 27.07%. Comparing base (c708025) to head (a392293).
⚠️ Report is 14 commits behind head on master.

Files with missing lines Patch % Lines
cmd/neofs-cli/modules/object/get.go 0.00% 62 Missing ⚠️
pkg/services/object/get/util.go 2.27% 43 Missing ⚠️
pkg/services/object/get/ec.go 46.93% 19 Missing and 7 partials ⚠️
pkg/services/object/get/prm.go 14.28% 17 Missing and 1 partial ⚠️
pkg/services/object/get/get.go 62.06% 10 Missing and 1 partial ⚠️
...kg/local_object_storage/blobstor/common/storage.go 80.00% 9 Missing ⚠️
pkg/local_object_storage/blobstor/fstree/fstree.go 60.00% 6 Missing and 2 partials ⚠️
...storage/blobstor/internal/storagetest/get_range.go 0.00% 7 Missing ⚠️
pkg/services/object/get.go 0.00% 7 Missing ⚠️
pkg/services/object/get/assembly_v2.go 14.28% 3 Missing and 3 partials ⚠️
... and 9 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4094      +/-   ##
==========================================
+ Coverage   26.81%   27.07%   +0.26%     
==========================================
  Files         675      676       +1     
  Lines       45943    46102     +159     
==========================================
+ Hits        12318    12482     +164     
+ Misses      32456    32427      -29     
- Partials     1169     1193      +24     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@roman-khimov roman-khimov left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Certainly can be simplified to some more common API at the lower level.

Comment thread pkg/network/cache/clients.go
Comment thread pkg/local_object_storage/blobstor/fstree/fstree.go Outdated
Comment thread pkg/local_object_storage/blobstor/fstree/fstree.go Outdated
Comment thread pkg/local_object_storage/blobstor/common/storage.go Outdated
Comment thread pkg/local_object_storage/writecache/get.go Outdated
Comment thread pkg/services/object/get/prm.go Outdated
Update the SDK for extended ranges and adapt to the client constructor change.

Signed-off-by: Andrey Butusov <andrey@nspcc.io>

@roman-khimov roman-khimov left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need some support from CLI as well to test it.

Comment thread pkg/local_object_storage/blobstor/common/storage.go Outdated
Comment thread pkg/services/object/get/util.go
Comment thread pkg/local_object_storage/engine/ec.go Outdated
Comment thread pkg/local_object_storage/shard/ec.go Outdated
Comment thread pkg/local_object_storage/blobstor/common/storage.go Outdated
Comment thread pkg/services/object/get/assembly_v2.go Outdated
Comment thread pkg/services/object/get/get.go
Comment thread pkg/services/object/server.go Outdated
Comment thread pkg/services/object/server.go Outdated
@End-rey
End-rey force-pushed the extended-range branch 3 times, most recently from 73913e5 to 87ffd0e Compare July 22, 2026 17:40
Comment thread cmd/neofs-cli/modules/object/get.go
Comment thread pkg/services/object/get/exec.go
End-rey added 3 commits July 23, 2026 15:04
Parse and forward extended GET ranges, resolving them once the payload length is
known.

Signed-off-by: Andrey Butusov <andrey@nspcc.io>
Add bounds, open-ended and suffix range forms to object get.

Signed-off-by: Andrey Butusov <andrey@nspcc.io>
Skip the buffered EC range path when the response header is needed to recheck
eACL.

Signed-off-by: Andrey Butusov <andrey@nspcc.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants