Skip to content

sn: return first found EC part when part index is missing#4033

Merged
roman-khimov merged 2 commits into
masterfrom
feat/EC-index-only-GET
Jul 7, 2026
Merged

sn: return first found EC part when part index is missing#4033
roman-khimov merged 2 commits into
masterfrom
feat/EC-index-only-GET

Conversation

@carpawell

@carpawell carpawell commented Jun 22, 2026

Copy link
Copy Markdown
Member

Implementation of nspcc-dev/neofs-api#393.
How other nodes should behave is a subject to be discussed.

@carpawell
carpawell force-pushed the feat/EC-index-only-GET branch from faa9e8d to a72d262 Compare July 2, 2026 18:26
@codecov

codecov Bot commented Jul 2, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 61.44578% with 64 lines in your changes missing coverage. Please review.
✅ Project coverage is 26.24%. Comparing base (36e6f25) to head (c7dac28).

Files with missing lines Patch % Lines
pkg/services/object/server.go 28.57% 30 Missing ⚠️
pkg/services/object/get/ec.go 64.00% 24 Missing and 3 partials ⚠️
pkg/local_object_storage/metabase/ec.go 78.26% 3 Missing and 2 partials ⚠️
pkg/services/object/get/prm.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4033      +/-   ##
==========================================
+ Coverage   26.18%   26.24%   +0.06%     
==========================================
  Files         673      673              
  Lines       45818    45946     +128     
==========================================
+ Hits        11998    12060      +62     
- Misses      32693    32755      +62     
- Partials     1127     1131       +4     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@carpawell
carpawell force-pushed the feat/EC-index-only-GET branch 2 times, most recently from 4ce8a94 to f9cf029 Compare July 3, 2026 08:19
Comment thread pkg/local_object_storage/engine/ec.go
Comment thread pkg/local_object_storage/engine/ec.go
Comment thread pkg/services/object/server.go
@carpawell
carpawell force-pushed the feat/EC-index-only-GET branch 2 times, most recently from 69a28ba to c82b984 Compare July 6, 2026 14:08
@carpawell
carpawell marked this pull request as ready for review July 6, 2026 14:08
@roman-khimov

Copy link
Copy Markdown
Member

CHANGELOG

carpawell added 2 commits July 7, 2026 16:05
If X-Headers do not include EC part ID, SN fills it with an ID that it should
store according to current Netmap. It such part cannot be found, it will
return first part ID it has locally. This does not relate any form of GETRAGE
reques, both GET with RANGE and native GETRAGE. This commit implements
nspcc-dev/neofs-api#393.

Signed-off-by: Pavel Karpy <carpawell@nspcc.io>
Signed-off-by: Pavel Karpy <carpawell@nspcc.io>
@carpawell
carpawell force-pushed the feat/EC-index-only-GET branch from c82b984 to c7dac28 Compare July 7, 2026 13:07
@carpawell

carpawell commented Jul 7, 2026

Copy link
Copy Markdown
Member Author

Rebased, fixed small bug, fixed go.sum.

@carpawell
carpawell requested a review from roman-khimov July 7, 2026 13:08
@roman-khimov
roman-khimov merged commit 602802f into master Jul 7, 2026
22 checks passed
@roman-khimov
roman-khimov deleted the feat/EC-index-only-GET branch July 7, 2026 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants