Fix/deposits#342
Merged
Merged
Conversation
This reverts commit 539fdd8. Commit does what it meant to do, but it breaks bootstrapping since the script is also reused in `up/bootstrap` make target with a different wallet (that does not have a second address in it). Signed-off-by: Pavel Karpy <carpawell@nspcc.io>
Use predefined test wallet instead. It has 1000 GAS on it after every start, and it is probably the best way to play with devenv: empty password, understandable path. Previously (many years before), most likely it was done this way cause there was no neo-go binary in the `vendor` repo but currently having neo-go docker container running equals having neo-go binary, so there is no practical differences. This also fixes the same problem 539fdd8 tried to do. Refs nspcc-dev#267. Signed-off-by: Pavel Karpy <carpawell@nspcc.io>
Signed-off-by: Pavel Karpy <carpawell@nspcc.io>
It is not deployed for a long time. Signed-off-by: Pavel Karpy <carpawell@nspcc.io>
carpawell
force-pushed
the
fix/deposits
branch
2 times, most recently
from
June 11, 2026 08:57
4538b94 to
e561f1b
Compare
carpawell
marked this pull request as draft
June 11, 2026 08:59
In most cases it will simply mean uncommenting this lines for regular neofs devs. Signed-off-by: Pavel Karpy <carpawell@nspcc.io>
carpawell
marked this pull request as ready for review
June 11, 2026 09:07
roman-khimov
approved these changes
Jun 11, 2026
End-rey
approved these changes
Jun 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The last one is arguable, worked for me, but it is docker's ENV field, found no spec about it.