Alphabet enhancement#609
Open
roman-khimov wants to merge 13 commits into
Open
Conversation
Can be traced back to e9ad34b as unused, makes no sense keeping it (it's len(validators) effectively). Signed-off-by: Roman Khimov <roman@nspcc.ru>
Committee doesn't have it, single chain using the same address is just a coincidence. Signed-off-by: Roman Khimov <roman@nspcc.ru>
Fetch nspcc-dev/neo-go#4362 fix. Signed-off-by: Roman Khimov <roman@nspcc.ru>
Signed-off-by: Roman Khimov <roman@nspcc.ru>
This doesn't fix all of them, but a subset required for alphabet contract tests in a proper multi-key committee setup. The problems are: * validators, not committee account gets NEO/GAS at block 0 * validators account is used to deploy contracts by default by Executor * some contracts require alpha signature and that's different from validators when committee and validator sets have different sizes * some contracts check for committee signatures for actions Signed-off-by: Roman Khimov <roman@nspcc.ru>
It's more realistic, alphabet is deployed per alpha node by this specific node (different senders yield different contract hashes). Signed-off-by: Roman Khimov <roman@nspcc.ru>
Follow up to 78e49b3, significantly deduplicating container contract tests. Signed-off-by: Roman Khimov <roman@nspcc.ru>
So stop passing them. Signed-off-by: Roman Khimov <roman@nspcc.ru>
container also doesn't care about proxy since b658629. Signed-off-by: Roman Khimov <roman@nspcc.ru>
Obsolete since b658629. Signed-off-by: Roman Khimov <roman@nspcc.ru>
They're all autodetected (contract hashes) or set (TLD) automatically with the same values. Signed-off-by: Roman Khimov <roman@nspcc.ru>
And deploy without them by default. Signed-off-by: Roman Khimov <roman@nspcc.ru>
Prove proxy and IR receive something. Signed-off-by: Roman Khimov <roman@nspcc.ru>
roman-khimov
force-pushed
the
alpha-optimization
branch
from
July 16, 2026 19:57
0cc5359 to
69c722d
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #609 +/- ##
==========================================
- Coverage 58.87% 58.61% -0.26%
==========================================
Files 29 29
Lines 3008 3023 +15
==========================================
+ Hits 1771 1772 +1
- Misses 1237 1251 +14 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.