Skip to content

Support for seki method thresholding in daily temporal interpolation #200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
trey-stafford merged 1 commit into from
Sep 29, 2025
Merged

Support for seki method thresholding in daily temporal interpolation #200

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions seaice_ecdr/nrt.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,8 +185,10 @@ def temporally_interpolated_nrt_ecdr_dataset(

data_stack = xr.concat(init_datasets, dim="time").sortby("time")

target_platform = PLATFORM_CONFIG.get_platform_by_date(date)
temporally_interpolated_ds = temporal_interpolation(
date=date,
platform=target_platform,
hemisphere=hemisphere,
resolution=NRT_RESOLUTION,
data_stack=data_stack,
Expand Down
25 changes: 22 additions & 3 deletions seaice_ecdr/temporal_composite_daily.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@

from seaice_ecdr._types import ECDR_SUPPORTED_RESOLUTIONS
from seaice_ecdr.ancillary import (
get_cdr_conc_threshold,
get_daily_climatology_mask,
get_non_ocean_mask,
nh_polehole_mask,
Expand All @@ -29,7 +30,7 @@
from seaice_ecdr.initial_daily_ecdr import (
read_or_create_and_read_idecdr_ds,
)
from seaice_ecdr.platforms import PLATFORM_CONFIG
from seaice_ecdr.platforms import PLATFORM_CONFIG, Platform
from seaice_ecdr.spillover import LAND_SPILL_ALGS
from seaice_ecdr.util import (
date_range,
Expand Down Expand Up @@ -203,6 +204,8 @@ def is_seaice_conc(
def temporally_composite_dataarray(
*,
target_date: dt.date,
platform: Platform,
hemisphere: Hemisphere,
da: xr.DataArray,
interp_range: int = 5,
one_sided_limit: int = 3,
Expand Down Expand Up @@ -362,8 +365,14 @@ def temporally_composite_dataarray(
# temporal_flags[have_only_next] = pdist[have_only_next] # CDRv04r00 error
temporal_flags[have_only_next] = ndist[have_only_next] # Correct

# Ensure that no conc values are between 0 and 10% after temporal interp
is_conc_too_low = (temp_comp_2d > 0) & (temp_comp_2d < 0.1)

@trey-stafford trey-stafford Sep 29, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Key change here - instead of a consistent threshold of 10%, utilize a threshold provided by get_cdr_conc_threshold, which returns a variable threshold based on DOY for AMSR2 data.

# Ensure that no conc values are between 0 and the threshold
conc_threshold_perc = get_cdr_conc_threshold(
date=target_date,
hemisphere=hemisphere,
platform=platform,
)
conc_threshold_frac = conc_threshold_perc / 100.0
is_conc_too_low = (temp_comp_2d > 0) & (temp_comp_2d < conc_threshold_frac)
temp_comp_2d[is_conc_too_low] = 0

# Ensure flag values do not occur over land
Expand Down Expand Up @@ -557,6 +566,7 @@ def filter_field_via_bitmask(
def temporal_interpolation(
*,
date: dt.date,
platform: Platform,
hemisphere: Hemisphere,
resolution: ECDR_SUPPORTED_RESOLUTIONS,
data_stack: xr.Dataset,
Expand Down Expand Up @@ -591,6 +601,8 @@ def temporal_interpolation(
# Actually compute the cdr_conc temporal composite
ti_var, ti_flags = temporally_composite_dataarray(
target_date=date,
hemisphere=hemisphere,
platform=platform,
da=data_stack.conc,
interp_range=interp_range,
non_ocean_mask=non_ocean_mask,
Expand Down Expand Up @@ -697,6 +709,8 @@ def temporal_interpolation(
# NOTE: the bt_conc array does not have daily_climatology applied
bt_conc, _ = temporally_composite_dataarray(
target_date=date,
hemisphere=hemisphere,
platform=platform,
da=data_stack.raw_bt_seaice_conc,
interp_range=interp_range,
non_ocean_mask=non_ocean_mask,
Expand All @@ -706,6 +720,8 @@ def temporal_interpolation(
# NOTE: the nt_conc array does not have daily_climatology applied
nt_conc, _ = temporally_composite_dataarray(
target_date=date,
hemisphere=hemisphere,
platform=platform,
da=data_stack.raw_nt_seaice_conc,
interp_range=interp_range,
non_ocean_mask=non_ocean_mask,
Expand Down Expand Up @@ -869,7 +885,10 @@ def temporally_interpolated_ecdr_dataset(

data_stack = xr.concat(init_datasets, dim="time").sortby("time")

target_platform = PLATFORM_CONFIG.get_platform_by_date(date)

tie_ds = temporal_interpolation(
platform=target_platform,
hemisphere=hemisphere,
resolution=resolution,
date=date,
Expand Down
9 changes: 9 additions & 0 deletions seaice_ecdr/tests/unit/test_temporal_composite_daily.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
from seaice_ecdr.constants import ECDR_PRODUCT_VERSION
from seaice_ecdr.initial_daily_ecdr import get_idecdr_dir, get_idecdr_filepath
from seaice_ecdr.platforms import SUPPORTED_PLATFORM_ID
from seaice_ecdr.platforms.config import F17_PLATFORM
from seaice_ecdr.temporal_composite_daily import (
iter_dates_near_date,
temporally_composite_dataarray,
Expand Down Expand Up @@ -109,6 +110,8 @@ def test_temporal_composite_max_interp_range_9():
with pytest.raises(RuntimeError, match=r"interp_range"):
temporally_composite_dataarray(
target_date=dt.date(2020, 1, 1),
hemisphere=NORTH,
platform=F17_PLATFORM,
da=xr.DataArray(coords=(range(2), range(3), range(4))),
interp_range=10,
non_ocean_mask=xr.DataArray([False, False, False]),
Expand Down Expand Up @@ -150,6 +153,8 @@ def test_temporal_composite_da_oneday():
# then the output will equal the input
temporal_composite, _ = temporally_composite_dataarray(
target_date=mock_date,
hemisphere=NORTH,
platform=F17_PLATFORM,
da=initial_data_array,
interp_range=0,
non_ocean_mask=xr.full_like(initial_data_array.isel(time=0), False, dtype=bool),
Expand Down Expand Up @@ -266,6 +271,8 @@ def test_temporal_composite_da_multiday():

temporal_composite, temporal_flags = temporally_composite_dataarray(
target_date=mock_date,
hemisphere=NORTH,
platform=F17_PLATFORM,
da=input_data_array,
interp_range=time_spread,
non_ocean_mask=xr.full_like(input_data_array.isel(time=0), False, dtype=bool),
Expand Down Expand Up @@ -351,6 +358,8 @@ def test_temporal_composite_da_multiday_nrt():

temporal_composite, temporal_flags = temporally_composite_dataarray(
target_date=mock_date,
hemisphere=NORTH,
platform=F17_PLATFORM,
da=input_data_array,
interp_range=5,
one_sided_limit=5,
Expand Down
Loading