Fix nrt time units calendar - #199
Merged
Merged
Conversation
Now the function sets the `time` parameter to have consistent units and calendar. Also Removes the FillValue from coordinate variables. This ensures that the daily outputs for both G10016 and G02202 are consistent Fixes an observed bug where the `time` variable has: * `units` attr that are based on the day of file creation * `calendar` attr that shows "proleptic_gregorian".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BUGFIX:
timevariable in published G10016 daily files now hasunitsattribute of "days since 1970-01-01" and sets the
calendarattribute to"standard". This resolves an issue where the
unitsattr was dependent on thefile creation date and the
calendarattribute showed"proleptic_gregorian". This ensures consistency between G10016 and G02202
daily output files.