fix: router delegates customize_prompt_builder with resolved model - #16
Merged
Conversation
RouterProvider inherited the default no-op for customize_prompt_builder, so provider-specific prompt customizations (e.g. Ollama injecting the <|think|> token for Gemma models) were silently skipped when routing through hints like "hint:gemma". Resolve the hint to the actual provider and model name before delegating.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
customize_prompt_builder, so provider-specific prompt customizations (e.g. Ollama injecting<|think|>for Gemma) were silently skipped when using routed hints likehint:gemmacustomize_prompt_builder#[derive(Clone)]onPromptContextto support creating a copy with the resolved model nameTest plan
customize_prompt_builder_delegates_with_resolved_modelverifies router resolves hint and passes real model name to inner providercustomize_prompt_buildertests pass (Ollama + Anthropic)<|think|>appears at the top of the system prompt in the trace