Add optional subnet and security group IDs inputs for preview deployment - #57
Open
tomarnebra wants to merge 11 commits into
Open
Add optional subnet and security group IDs inputs for preview deployment#57tomarnebra wants to merge 11 commits into
tomarnebra wants to merge 11 commits into
Conversation
tomarnebra
changed the title
tomarnebra
marked this pull request as ready for review
July 2, 2026 13:20
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extends the ECS Express preview deployment composite action to optionally accept explicit subnet IDs and security group IDs and pass them to the service creation command as a network configuration override.
Changes:
- Added optional
subnet-idsandsecurity-group-idsinputs to the composite action. - Added logic to conditionally append
--network-configurationto theaws ecs create-express-gateway-servicecall.
Changed files:
.github/actions/deployment/preview/deploy-ecs-express-service/action.yml
Validation result:
.github/actions/deployment/preview/deploy-ecs-express-service/action.yml: ❌ Error (YAML becomes invalid due to unescaped quotes in new descriptions; bash/JSON quoting breaks when real JSON arrays are provided)
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
…allers diagnose misformatted values Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Comment on lines
+36
to
+39
| subnet-ids: | ||
| description: 'JSON array of subnet IDs for the service, e.g. ["subnet-abc"]. Must be provided together with security-group-ids.' | ||
| required: false | ||
| default: '' |
Comment on lines
+40
to
+43
| security-group-ids: | ||
| description: 'JSON array of security group IDs for the service, e.g. ["sg-abc"]. Must be provided together with subnet-ids.' | ||
| required: false | ||
| default: '' |
Comment on lines
+184
to
+188
| NETWORK_ARGS=() | ||
| if [ -n "$SECURITY_GROUP_IDS" ] && [ -z "$SUBNET_IDS" ]; then | ||
| echo "Error: subnet-ids must be set when security-group-ids are provided." | ||
| exit 1 | ||
| fi |
…form-actions into vpc-option-preview-deployment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.