chore(repo): bump pnpm to 11.22.0 - #36753
Open
FrozenPandaz wants to merge 3 commits into
Open
Conversation
✅ Deploy Preview for nx-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for nx-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
|
View your CI Pipeline Execution ↗ for commit 6f3def3
☁️ Nx Cloud last updated this comment at |
The inferred types of the exported rule objects reference RuleModule and
RuleListener from @typescript-eslint/utils. With nothing naming those types
explicitly, tsgo emits a reference through the resolved node_modules/.pnpm
store path, which fails with TS2883 ("cannot be named ... not portable").
This surfaced under pnpm 11.22.0 on Linux only. pnpm 11.15.0 changed optional
peer resolution so that peers declared solely via peerDependenciesMeta - such
as debug's supports-color - resolve from a version already present in the
dependency graph. That graph differs per platform, so eslint gains a
supports-color peer suffix on Linux but not on macOS, and the suffix
propagates into @typescript-eslint/utils. The lockfile is unaffected; a clean
frozen install on macOS reproduces neither the suffix nor the failure.
Annotating explicitly removes the dependency on node_modules layout entirely,
so this holds regardless of how peers are hashed on any platform.
resolve-workspace-rules.ts already uses this pattern.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current Behavior
The repo pins pnpm
11.2.2, which is ~20 minor releases behind the current11.22.0. The version is pinned in four places that must stay in sync:package.jsonpackageManager.github/workflows/publish.yml(PNPM_VERSIONenv + a hardcoded global install).github/workflows/issue-notifier.yml(pnpm/action-setupversion).github/workflows/generate-embeddings.yml(pnpm/action-setupversion)Expected Behavior
All four pins move to pnpm
11.22.0. This stays within the same major, so no lockfile or config migration is involved —pnpm install --frozen-lockfilewas verified to pass unchanged on 11.22.0 locally (all 121 workspace projects,lockfileVersion: 9.0untouched, supply-chain policy check green).Other
11.2.2occurrences in the repo are unrelated unit-test fixtures and version strings tied to specific documented pnpm behaviors, so they are intentionally left alone.Related Issue(s)
N/A — routine toolchain maintenance.
View Polygraph session ↗