Repository navigation
Product finishing: badge embed, QR rendering, registry HTTP surface - #12
Merged
Merged
Conversation
Deploying axiomcode-site with
|
| Latest commit: |
5e9715a
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://72338317.axiomcode-site.pages.dev |
| Branch Preview URL: | https://wright-product-finishing.axiomcode-site.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Product finishing — the last product-side mile before first revenue
Implements the three remaining SPEC open items: badge embed, QR image rendering, registry HTTP hosting.
Badge embed (
core/badge.py,axiomcode badge)/badge/<serial>.svg, so a copied badge can never claim a false status — a revoked cert's badge turns red everywhere it is embedded, automatically.QR rendering (
core/qr.py,axiomcode qr)segno(zero dependencies) renders the certificate's QR payload as PNG/SVG. Uses the signature-coveredqr_payloadwhen set, else the canonical verification URL.segnoadded to requirements.txt.Registry HTTP surface (
services/registry_app.py,axiomcode serve-registry)/storefront,/health,/api/registry(active;?status=allfull transparency log),/api/export(agent machine-readable),/api/cert/<serial>,/cert/<serial>(human page with QR + badge snippet),/badge/<serial>.svg(live),/qr/<serial>.png.Behavior-test evidence (terminal-confirmed, not just CI)
tests/test_product_finishing.py: revoked badge renders "Revoked" (never "Certified"); tampered registry cert → badge "Invalid signature"; QR PNG has valid magic bytes and payload differentiation; HTTP: active list excludes revoked/expired,?status=allincludes them, per-cert JSON carries signature+verify_key, badge endpoint reflects live revoked status, QR endpoint returns PNG, POST→405, path traversal rejected.ruff check+ruff format --checkclean.Follow-ups (out of scope, noted)
services/api/(verify_api.py, certs.py) is a pre-P0 prototype using HMAC certs and importing fastapi (not in requirements) — inconsistent with the Ed25519 architecture. Recommend deprecating/removing in a follow-up PR.