Skip to content

Error while filtering an editable grid with an uncommitted cell#1

Open
jsiulian wants to merge 1 commit into
npolyak:mainfrom
jsiulian:bugfix_uncommitted_filtering
Open

Error while filtering an editable grid with an uncommitted cell#1
jsiulian wants to merge 1 commit into
npolyak:mainfrom
jsiulian:bugfix_uncommitted_filtering

Conversation

@jsiulian

@jsiulian jsiulian commented Jul 30, 2024

Copy link
Copy Markdown

Hi Nick,

I've been using your DataGrid filtering functionality for a while and it's been great! I've found an issue in one of my new usecases and have proposed a fix. Please have a look below:

Replicating the problem:

  1. Have a DataGrid with column filtering and cell editing enabled.
  2. Edit a cell, but do not press Enter or commit the change in any way
  3. Attempt to filter by typing into the column header textbox.

Actual behaviour:
An error is reported in a tooltip attached to a red exclamation mark in the column filter textbox, and filtering does not occur.

Expected behaviour:
Filtering should be allowed even while a cell is being actively edited.

Solution:
Committing the cell changes prior to building the filter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant