Error while filtering an editable grid with an uncommitted cell#1
Open
jsiulian wants to merge 1 commit into
Open
Error while filtering an editable grid with an uncommitted cell#1jsiulian wants to merge 1 commit into
jsiulian wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Nick,
I've been using your DataGrid filtering functionality for a while and it's been great! I've found an issue in one of my new usecases and have proposed a fix. Please have a look below:
Replicating the problem:
Actual behaviour:
An error is reported in a tooltip attached to a red exclamation mark in the column filter textbox, and filtering does not occur.
Expected behaviour:
Filtering should be allowed even while a cell is being actively edited.
Solution:
Committing the cell changes prior to building the filter.