Repository navigation
fix: strip inline comments after quoted values - #315
Open
vhinayindia wants to merge 1 commit into
Open
vhinayindia wants to merge 1 commit into
vhinayindia wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Strip a trailing
;or#comment from a complete quoted value before existing quote decoding runs. This prevents quote marks from remaining in the parsed value when an inline comment follows.Adds regression cases for single- and double-quoted values, delimiters inside quoted values, and an unquoted value with an inline comment.
Fixes #89.
Validation
npm exec -- tap --no-coverage test/quoted-values.js— passed on Node 24.15.0.npm test— all six test files pass with 100% coverage, and ESLint passes. The command exits 1 intemplate-oss-checkbecause it reports drift in unchanged generated files:.github/dependabot.yml,.github/settings.yml,.github/workflows/ci.yml,.github/workflows/codeql-analysis.yml, and.github/workflows/release.yml.npm run eslint— passed on Node 24.15.0.