Skip to content

fix: parse comments following quoted values #311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
amtbsl wants to merge 2 commits into from
Closed

fix: parse comments following quoted values #311

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fa57015
fix: parse comments after quoted values
amtbsl Aug 29, 2026
14796a9
test: cover comments after quoted values
amtbsl Aug 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions lib/ini.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,6 +229,31 @@ const safe = val => {

const unsafe = val => {
val = (val || '').trim()
if (val.charAt(0) === '"' || val.charAt(0) === "'") {
let quote = null
let escaped = false
let commentIndex = -1
for (let i = 0; i < val.length; i++) {
const c = val.charAt(i)
if (escaped) {
escaped = false
} else if (c === '\\') {
escaped = true
} else if (quote) {
if (c === quote) {
quote = null
}
} else if (c === '"' || c === "'") {
quote = c
} else if (c === ';' || c === '#') {
commentIndex = i
break
}
}
if (commentIndex !== -1) {
val = val.slice(0, commentIndex).trim()
}
}
if (isQuoted(val)) {
// remove the single quotes before calling JSON.parse
if (val.charAt(0) === "'") {
Expand Down
6 changes: 6 additions & 0 deletions test/foo.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,12 @@ test('decode from file', function (t) {
t.end()
})

test('decode quoted values before inline comments', function (t) {
const d = i.decode('double = "value" ; comment\nsingle = \'value\' # comment\n')
t.same(d, { double: 'value', single: 'value' })
t.end()
})

test('encode from data', function (t) {
const d = i.decode(data)
const e = i.encode(d)
Expand Down