Skip to content

move to node:test - #289

Closed
wraithgar wants to merge 4 commits into
mainfrom
gar/node-tests
Closed

wraithgar wants to merge 4 commits into
mainfrom
gar/node-tests

Conversation

@wraithgar

Copy link
Copy Markdown
Contributor

This includes a breaking change bumping engines.

@wraithgar
wraithgar requested a review from a team as a code owner October 21, 2025 04:24
@cjihrig

cjihrig commented Oct 21, 2025

Copy link
Copy Markdown

Just as an FYI, there is no glob support in Node v20. It has caused a lot of headaches, but the core team has refused to backport globbing.

@wraithgar

wraithgar commented Oct 21, 2025 •

Copy link
Copy Markdown
Contributor Author

Just as an FYI, there is no glob support in Node v20. It has caused a lot of headaches, but the core team has refused to backport globbing.

Do you mean the globbing in node --test foo/**/*.js?

ETA: yep looks like that's what you're referring to

 > ini@5.0.0 test
> node --test './test/**/*.js'

Could not find '/home/runner/work/ini/ini/test/**/*.js'

@wraithgar

Copy link
Copy Markdown
Contributor Author

Still need to also investigate why the 22.x tests are failing in mac and linux.

@cjihrig

cjihrig commented Oct 21, 2025

Copy link
Copy Markdown

Correct, the test runner does not support globbing in v20. I know of at least one project, borp, that was created just to paper over a few differences across versions.

@wraithgar

Copy link
Copy Markdown
Contributor Author

For now we're gonna let the shell do the globbing.

@owlstronaut owlstronaut closed this Jan 7, 2026
@owlstronaut
owlstronaut deleted the gar/node-tests branch January 7, 2026 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants