Repository navigation
Conversation
BREAKING CHANGE: `ini` now supports node `^20.17.0 || >=22.9.0`
wraithgar
force-pushed
the
gar/node-tests
branch
from
October 21, 2025 04:27
34052fb to
7e9d896
Compare
|
Just as an FYI, there is no glob support in Node v20. It has caused a lot of headaches, but the core team has refused to backport globbing. |
Contributor
Author
Do you mean the globbing in ETA: yep looks like that's what you're referring to |
Contributor
Author
|
Still need to also investigate why the 22.x tests are failing in mac and linux. |
|
Correct, the test runner does not support globbing in v20. I know of at least one project, borp, that was created just to paper over a few differences across versions. |
Contributor
Author
|
For now we're gonna let the shell do the globbing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This includes a breaking change bumping engines.