migrate desktop runtime to OMP#11
Draft
novvoo wants to merge 4 commits into
Draft
Conversation
|
Analysis CompleteGenerated ECC bundle from 1 commits | Confidence: 75% View Pull Request #12Repository Profile
Changed Files (300)
Top hotspots
Top directories
Analysis Depth Readiness (evidence-backed, 64%)ECC Tools uses this to decide whether recommendations should stay at commit-history/setup guidance or expand into CI, security, harness, reference-set, AI-routing, and team backlog work.
Reference Set Readiness (1/7, 14%)
Likely Future Issues (7)
Suggested Follow-up Work (7)
Copy-ready bodies chore: sync config templates for src/core/config/app-config.js + src/core/config/index.js ## Summary
- Update the example env files, sample configs, or deployment templates that should mirror the changed runtime configuration surface.
## Why
- Backfill example env files or config templates before a fresh setup drifts from the shipped runtime surface.
## Touched paths
- `src/core/config/app-config.js`
- `src/core/config/index.js`
## Validation
- Update the repo example env file or config template that should reflect the new runtime settings.
- Run the setup, boot, or deployment validation flow that depends on the changed config surface.test: add auth coverage for desktop/renderer/app/session/session-storage.js + src/core/harness/hashline/policy.js ## Summary
- Add auth, session, or permission regression coverage for the recently changed security-sensitive surface.
## Why
- Backfill auth or permission regression coverage before another access-control change lands on the touched surface.
## Touched paths
- `desktop/renderer/app/session/session-storage.js`
- `src/core/harness/hashline/policy.js`
## Validation
- Add or extend integration / e2e coverage for the changed auth, session, middleware, or permission surface.
- Exercise allowed and denied flows, invalid or expired credentials, or equivalent access-control boundary cases.test: add async coverage for src/scheduler/SchedulerEngine.js + src/scheduler/concurrency/ConcurrencyCoordinator.js ## Summary
- Add async reliability coverage for the recently changed queue, worker, cron, or webhook surface.
## Why
- Backfill async reliability coverage before another queue, worker, or webhook change lands on the touched surface.
## Touched paths
- `src/scheduler/SchedulerEngine.js`
- `src/scheduler/concurrency/ConcurrencyCoordinator.js`
## Validation
- Add or extend integration / e2e coverage for the changed queue, worker, cron, or webhook behavior.
- Exercise retries, idempotency, failure handling, or equivalent async boundary cases.test: add browser coverage for desktop/renderer/components/AgentControl.jsx + desktop/renderer/components/AskUserFloatingCapsule.jsx ## Summary
- Add browser or end-to-end coverage for the recently changed user-facing surface.
## Why
- Backfill browser coverage before another user-facing UI change lands on the touched surface.
## Touched paths
- `desktop/renderer/components/AgentControl.jsx`
- `desktop/renderer/components/AskUserFloatingCapsule.jsx`
## Validation
- Add or extend browser / e2e coverage for the changed component, page, or flow.
- Exercise the visible user journey that depends on the touched UI surface.test: add CLI coverage for src/adapters/cli/index.js + src/adapters/cli/ui-adapter.js ## Summary
- Add shell, CLI, or end-to-end coverage for the recently changed command surface.
## Why
- Backfill CLI coverage before another command-surface change lands on the touched paths.
## Touched paths
- `src/adapters/cli/index.js`
- `src/adapters/cli/ui-adapter.js`
## Validation
- Add or extend shell, CLI, or end-to-end coverage for the changed command surface.
- Exercise the user-facing command invocation and expected exit/output behavior.test: add budget evidence for desktop/main-app/llm-config-and-persistence.js + src/core/prompts/coding-prompts.js ## Summary
- Add budget or usage-limit validation for the recently changed AI routing or model-call surface.
## Why
- Backfill cost, token, or usage-limit validation before another model-routing change lands on the touched surface.
## Touched paths
- `desktop/main-app/llm-config-and-persistence.js`
- `src/core/prompts/coding-prompts.js`
## Validation
- Add or extend budget, token, usage-limit, or model-routing regression coverage for the changed path.
- Verify the route still enforces plan limits, retry caps, fallback behavior, or explicit cost controls.ci: add failure-mode evidence for .github/workflows/ci.yml ## Summary
- Add CI failure-mode evidence for the recently changed workflow or test-runner surface.
## Why
- Backfill CI failure-mode evidence before another workflow or test-runner change lands on the touched surface.
## Touched paths
- `.github/workflows/ci.yml`
## Validation
- Add or update a CI failure fixture, captured failing log, troubleshooting note, workflow dry-run evidence, or regression test for the changed CI/test-runner behavior.
- Run the affected workflow or test-runner entrypoint locally or in CI and record pass/fail evidence.Generated Instincts (14)
After merging, import with: Files
|
MessageLog: - Tighten all spacing: margins, padding, gaps across message items, bubbles, tool cards, thinking panels, detail panels, runtime details - Unify font sizes to 10/11/13px three-tier system - Reduce header visual weight, soften type labels - Fix markdown rendering: p line-height 1.05→1.45, shrink code blocks - Compact inline JSX styles for events, payloads, error pres BottomTerminalPanel: - Full rewrite with DS token alignment (var(--ds-*)) - Add ANSI color code parsing for terminal output - Replace plain-text buttons (C, _, x) with inline SVG icons - Redesign tab bar with segmented control style - Add completion popup, command-line highlight, brand caret - Compact header (42px→34px), tighter input row - Add empty state for Problems tab
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
@oh-my-pi/pi-coding-agentWhy
The desktop application had switched execution cores, but still carried the previous runtime and UI assumptions. This made initialization fragile, duplicated behavior, left runtime events mismatched, and caused the old CI workflow to target deleted test paths.
Impact
The desktop app now uses OMP as the single execution core while preserving the existing Electron IPC boundary. The renderer presents normalized sessions, streaming output, tool lifecycle events, file changes, user interactions, and responsive workbench states through one coherent UI.
Validation
bun install --frozen-lockfilebun run lintbun run test:unit— 380 passedbun run test:desktop— 21 passed, repeated twicebun run desktop:renderer:buildnpm pack --dry-rungit diff --check