(Inconclusive results) Event performance improvements#416
Open
nicholasgower wants to merge 9 commits into
Open
(Inconclusive results) Event performance improvements#416nicholasgower wants to merge 9 commits into
nicholasgower wants to merge 9 commits into
Conversation
… discovery Maraxsis."
sync from main
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here's some work I did to port Muluna's improvements to the event handler to Maraxsis, adding event filters to all on_built() events. While I think there is value in my improvements to the event handler, whether or not it actually improved performance is inconclusive, due to the massive number of entities and entity types that must be added to the dome-related on_built() events. I'm not certain you should merge this, but you may find the approach I took interesting.