Refactor/docs rules presets - #2
Merged
Merged
Conversation
Drop benchmarks, sync scripts, workflow, and website page so the project focuses on linting and documentation instead of public score rankings.
Introduce @dbt-doctor/manifest for loading and normalizing manifest.json so lint rules can analyze the DAG without a warehouse connection.
Add manifest path, phase4 thresholds, and ruleConfig fields so CLI and core can share one typed configuration surface.
Load dotted rule options from .dbt-doctor, apply default/strict/enterprise presets via tag filters, and validate ruleConfig plus phase4 thresholds.
Add 70+ rules for DAG governance, meta/testing contracts, native SQL style, and configurable policies. Promote structural layering and config violations to error severity so default CI gates catch DAG breaks early.
Expose coverage summaries, per-model scores, manifest path overrides, and preset application in inspect so CI can gate on docs/tests coverage.
Ship markdown docs with sidebar navigation, generated rules catalog, tool parity pages, copy-link headings, and GitHub star count on the landing page.
Replace leaderboard npm scripts with docs generators, add manifest to the fixed release group, and tune turbo test dependencies.
Rewrite the presets page with a decision tree, layer diagram, and plain language so default vs strict vs enterprise (and omitting preset) is obvious.
The generated Rules reference on the site is the canonical catalog; drop the duplicated maintainer markdown file and update repo links accordingly.
strict now runs native SQL formatting checks for PR CI; enterprise runs the full 122-rule catalog instead of skipping the style tier.
Stack link and check icons in one grid cell, route clicks through the button, and use native clipboard delegation with an execCommand fallback.
Next.js 16 requires route segment config values to be statically analyzable; importing revalidate from a constant caused the production build to fail.
Ignore YAML structural keys when counting schema tests, create fixture dirs in the trailing-newline test, type SQL style rule diagnostics, and export phase4 metric types from @dbt-doctor/types.
Drop config.baseline, --write-baseline, and fingerprint filtering so scans always report the full diagnostic set without a sidecar baseline file.
Replace phase4-named helpers with coverage-metrics and score-thresholds so inspect output matches the public coverage/score terminology.
Align style-tier ignore tags with public docs and apply the default preset when config.preset is omitted.
Register manifest, source, jinja, and SQL style rules migrated from external linters so strict/enterprise presets can enforce parity without sqlfluff-parity.json.
Replace monolithic phase1/phase5 test files with targeted suites for manifest, checkpoint, score, and sql-style rule families.
Regenerate rules and parity docs from the registry, split preset guidance into dedicated pages, and add score-modes documentation.
Regenerate rules and tool-parity docs after vp fmt so generated markdown matches the formatter output CI enforces.
CI runs build before format:check, and prebuild regenerates rules docs without formatting. Run vp fmt on generated paths so format:check stays green.
Tag dbt-checkpoint, dbt-score, and new SQL rules with strict, enterprise, or sql-style so default stays quiet. Document score thresholds, SQLFluff migration, and remove dbt_project_evaluator references from user-facing docs.
SQLFluff exits without violations when no dialect is set. Map project adapter to --dialect and trim compatibility tests to stable ansi pairs.
Guard docs/tool-parity/sqlfluff.md so all 74 codes stay covered and link to registered dbt-doctor rule ids.
joachimhodana
added a commit
that referenced
this pull request
May 31, 2026
Bump dbt-doctor, rules, types, manifest, and core for the parity/presets release after merging PR #2.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.