fix: recalibrate FG-002/FG-003 high band to match real exploitability#23
Merged
Conversation
The high-severity band was inflated by two low-actionability classes, drowning the genuinely attacker-controllable findings. - FG-002 Script Injection: `inputs.*` / `github.event.inputs.*` are populated only by a write-gated manual dispatch or an internal workflow_call — not reachable from an untrusted trigger. Drop those a tier (high -> medium). Attacker-controllable expressions (pull_request.title, head_commit.message, comment.body, head_ref, etc.) stay high. - FG-003 Tag-Based Pinning: branch pins (@main/@master/@dev) are supply-chain hygiene, not an acute exploit. Cap at medium (down from high) with a "mutable branch ref" note; version tags stay medium, first-party actions/* stay info. Measured on a 277-repo mid-tier corpus: high-severity findings drop 989 -> 171 (-83%), the two real pwn-request criticals are untouched, and every surviving FG-002 high is an attacker-controllable expression. Adds positive-control fixtures/tests: pull_request.title injection stays high; third-party @main pin is medium. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Triaging a mid-tier scan surfaced that the high-severity band was inflated by two low-actionability classes, drowning out the genuinely attacker-controllable findings.
inputs.*/github.event.inputs.*are populated only by a write-gated manual dispatch or an internalworkflow_call; they're never reachable directly from an untrusted trigger. Those drop a tier (high → medium, with a note to verify reusable-workflow callers). Attacker-controllable expressions (pull_request.title,head_commit.message,comment.body,head_ref, …) stay high.@main/@master/@dev) are supply-chain hygiene, not an acute exploit. Capped at medium (down from high) with a "mutable branch ref" note. Version tags stay medium; first-partyactions/*stay info.Measured impact (277-repo mid-tier corpus)
The high band now means "an untrusted actor can influence this," which is the point.
Testing
pull_request.titleinjection stays high; third-party@mainpin is medium.go test ./..., gofmt, vet, and self-scan clean.🤖 Generated with Claude Code