new configuration values for open desk environment by nurjinjafar · Pull Request #127 · nordeck/matrix-neoboard-standalone

nurjinjafar · 2026-08-27T08:36:10Z

with some extra hardcoded values for testing purposes to emulate opendesk environment

neoboard.appearance.mov

opendesk.appearance.mov

✔️ Checklist

A changeset describing the change and affected packages (more info).
Added or updated documentation.
Tests for new functionality and regression tests for bug fixes.
Screenshots or videos attached (for UI changes).
All your commits have a Signed-off-by line in the message (more info).

Signed-off-by: nurjinn jafar <nurjin.jafar@nordeck.net>

changeset-bot · 2026-08-27T08:36:15Z

🦋 Changeset detected

Latest commit: a978d54

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@nordeck/matrix-neoboard-standalone	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Signed-off-by: nurjinn jafar <nurjin.jafar@nordeck.net>

mgcm · 2026-09-08T15:34:54Z

@@ -0,0 +1,90 @@
+{


I understand these temporary files are useful for testing the new design but I think they should not be part of the repository, so let's not forget to remove them once this is completed.

mgcm · 2026-09-08T15:35:31Z

@@ -0,0 +1,13 @@
+<!doctype html>


Same as the navigation.json, these should be used for testing and removed before merging.

mgcm · 2026-09-08T15:43:34Z

        ? 'neoboard'
-        : ''
+        : 'Whiteboard'
      : (roomNameState?.entities[roomId]?.content.name ?? 'neoboard');


The same logic would also apply here - in the very uncommon case of a room without a name, the text shown here should also be "Whiteboard" if running on openDesk.

Ideally, I'd rather have a REACT_APP_PRODUCT_NAME env that defaults to 'NeoBoard` and uses that here, like:

roomId === undefined ? productName : (roomNameState?.entities[roomId]?.content.name ?? productName);

where

const productName = getEnvironment( 'REACT_APP_PRODUCT_NAME', 'NeoBoard', );

and it would be override to Whiteboard on openDesk deployments

mgcm · 2026-09-08T15:45:17Z

      banner: {
        ics_navigation_json_url: getEnvironment(
          'REACT_APP_OPENDESK_BANNER_ICS_NAVIGATION_JSON_URL',
+          `${window.location.origin}/tmp/navigation.json`,


we should not default to a temporary file here - the env variables should be mandatory.

these are just for PR purposes. the same goes for the hardcoded files regarding navigation and silent.html

mgcm · 2026-09-08T15:45:35Z

        ),
        ics_silent_url: getEnvironment(
          'REACT_APP_OPENDESK_BANNER_ICS_SILENT_URL',
+          `${window.location.origin}/tmp/silent.html`,


Same as previous comment.

mgcm · 2026-09-08T16:01:20Z

  });

-  it('logs in silently', () => {
+  it.todo('logs in silently', () => {


why are we changing this?

because the build fails on navbar if we set the loggedin state to true. which we need for the navigation to simulate opendesk env. and if that is set to true the tests fail. but these also would be reverted

mgcm · 2026-09-08T16:04:27Z

  const { t, i18n } = useTranslation();
  const [ariaExpanded, setAriaExpanded] = useState(false);
-  const [loggedIn, setLoggedIn] = useState(false);
+  const [loggedIn, setLoggedIn] = useState(true);


needs to change back to false, I assume this was for testing?

mgcm · 2026-09-08T16:13:16Z

+  '#f5f8fa',
+);
+
+// opendesk navbar styling


these // opendesk nabber styling comments being repeated on every property don't add any value - we either have like a section separator comment indicating that all the above properties are specific to openDesk styling or take time to specify how each property affects the style.

mgcm · 2026-09-08T16:16:39Z

+// opendesk navbar styling
+const backgroundHover = getEnvironment(
+  'REACT_APP_OPENDESK_BANNER_BACKGROUND_COLOR_HOVER',
+  '#f5f8fa',


We should go thru all the defaults as I think they are not fully matching the Figma design.

mgcm · 2026-09-08T16:17:13Z


 export function getEnvironmentAppearance(): string {
-  return getEnvironment('REACT_APP_APPEARANCE', 'neoboard');
+  return getEnvironment('REACT_APP_APPEARANCE', 'opendesk');


I think we should not change the default appearance to be openDesk.

true! but again it is for testing purposes for the PR

…of navbar Signed-off-by: nurjinn jafar <nurjin.jafar@nordeck.net>

Signed-off-by: nurjinn jafar <nurjin.jafar@nordeck.net> Signed-off-by: nurjinn jafar <nurjin.jafar@nordeck.net>

Signed-off-by: nurjinn jafar <nurjin.jafar@nordeck.net>

new configuration values for open desk environment

6e53242

Signed-off-by: nurjinn jafar <nurjin.jafar@nordeck.net>

nurjinjafar requested a review from a team as a code owner August 27, 2026 08:36

nurjinjafar added 10 commits August 27, 2026 11:09

new configuration values for open desk environment

179a512

Signed-off-by: nurjinn jafar <nurjin.jafar@nordeck.net>

new configuration values for open desk environment

15db3a5

Signed-off-by: nurjinn jafar <nurjin.jafar@nordeck.net>

new configuration values for open desk environment

f36cdd8

Signed-off-by: nurjinn jafar <nurjin.jafar@nordeck.net>

new configuration values for open desk environment

9813379

Signed-off-by: nurjinn jafar <nurjin.jafar@nordeck.net>

changeset added

6f7f12d

Signed-off-by: nurjinn jafar <nurjin.jafar@nordeck.net>

fix year in notice header

3b6430e

Signed-off-by: nurjinn jafar <nurjin.jafar@nordeck.net>

refactor portal, logo, logo_width to optional variables section

361b1cf

Signed-off-by: nurjinn jafar <nurjin.jafar@nordeck.net>

fix title color based on appearance and adjusted launcher styling

d0aab86

Signed-off-by: nurjinn jafar <nurjin.jafar@nordeck.net>

fix prettier issues

0173840

Signed-off-by: nurjinn jafar <nurjin.jafar@nordeck.net>

add missing logo width value to config banner

f143bee

Signed-off-by: nurjinn jafar <nurjin.jafar@nordeck.net>

mgcm requested changes Sep 8, 2026

View reviewed changes

nurjinjafar added 4 commits September 9, 2026 09:52

revert configurations regarding logo and show it on the menu instead …

e497d06

…of navbar Signed-off-by: nurjinn jafar <nurjin.jafar@nordeck.net>

configurable product home icon and name

319d438

Signed-off-by: nurjinn jafar <nurjin.jafar@nordeck.net> Signed-off-by: nurjinn jafar <nurjin.jafar@nordeck.net>

apply theme colors from design and update documentation

104cb4c

Signed-off-by: nurjinn jafar <nurjin.jafar@nordeck.net>

fix color on hover

a978d54

Signed-off-by: nurjinn jafar <nurjin.jafar@nordeck.net>

Uh oh!

Conversation

nurjinjafar commented Aug 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot Bot commented Aug 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

nurjinjafar commented Aug 27, 2026 •

edited

Loading

changeset-bot Bot commented Aug 27, 2026 •

edited

Loading