Repository navigation
deliverables: fix the production build of the public page - #109
Merged
Merged
Conversation
…browser The page component called bodyOpensWithTitle from deliverables.server, which React Router refuses to bundle for the client, so `react-router build` failed and the Deploy run for #107 stopped at staging. The server now decides it and sends `showTitle` with the rest of the page. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Deploy run for #107 failed at staging:
react-router buildrefusedpublic.deliverable.$fileId.tsxbecause its component importedbodyOpensWithTitlefromdeliverables.server. Production wasn't touched.showTitleindeliverablePage; the component reads it and no longer imports server codeshowTitleChecked locally:
pnpm --filter fruits run buildpasses (it reproduced the deploy error before the fix), deliverables tests 22/22,tscclean, and the worker's production image builds (it only builds in the production job, and its Chromium change hasn't shipped yet).Why CI missed it: CI runs tests and type checks but not the production build.
🤖 Generated with Claude Code