Standardise character limits for Calico cluster l3out name and system-id - #856
Standardise character limits for Calico cluster l3out name and system-id#856pkharat wants to merge 1 commit into
Conversation
| l3out_name = "calico-l3out-fsvi-vlan-%s" % vlan_id | ||
| config["aci_config"]["cluster_l3out"]["name"] = l3out_name | ||
| l3out_name = config["aci_config"]["cluster_l3out"]["name"] | ||
| config["aci_config"]["cluster_l3out"]["name"] = l3out_name + "-" + get_md5_hash(l3out_name)[:6] |
There was a problem hiding this comment.
@snaiksat confirm plz :
whether cluster_l3out name is passed through input file or not, always append a hash to it.
| return str(n) | ||
|
|
||
|
|
||
| def get_md5_hash(str): |
There was a problem hiding this comment.
@snaiksat This PR is for Issue - https://github.com/noironetworks/support/issues/1952 (Referring issue in the comment for context purpose only)
Is the change required only for cko-mvp-1 branch (as per the issue) ?
Or its needed for master and kmr2 branches as well ?
|
@pkharat thanks for working on this - (1) I dont think this change is ready, until then please make this a "draft" PR, (2) please follow commit title and commit message conventions, (3) please squash commits when ready. |
@snaiksat yes its in progress and marked it the same now. Can you please confirm couple of things asked above ? |
b4207e0 to
aae2039
Compare
Generate a md5 hash from cluster_l3out and system_id names and append first 6 chars of this hash in the cluster_l3out and system_id name respectively
f97ce38 to
c1e7a55
Compare
2 participants
No description provided.