added helm chart for aci operator and helm option to acc-provision - #683
added helm chart for aci operator and helm option to acc-provision#683siva-muni wants to merge 1 commit into
Conversation
a4046bc to
8a3d638
Compare
8a3d638 to
e8818fc
Compare
|
Could we use the acc-provision command to generate helm chart package itself rather than creating the directory structure in this repo? This package can be generated using a different argument from the one you are using for generating the values. The package can be generated and pushed to a helm repo any time acc-provision is released. |
| namespace: {{ default "aci-containers-system" (.Values.kubeConfig).system_namespace }} | ||
| --- | ||
| apiVersion: {{ default "apps/v1" (.Values.kubeConfig).use_apps_api }} | ||
| kind: Deployment |
There was a problem hiding this comment.
Maybe we could separate Deployment from RBAC objects?
| [-p pass] [-w timeout] [--list-flavors] [-f flavor] | ||
| [-t token] [--test-data-out file] [--skip-kafka-certs] | ||
| [--upgrade] [--disable-multus disable_multus] | ||
| [--upgrade] [--disable-multus disable_multus] [--helm] |
There was a problem hiding this comment.
Could we have two flags here:
- [--helm-values file]
- [--helm-chart file] = a generated aci-helm.tar.gz chart (equivalent to output of
helm package)
Or
- [--helm dir] which generates both files at the dir
| To install | ||
| ----------- | ||
|
|
||
| helm install <helm-rel-name> aci-helm |
| @@ -0,0 +1,167 @@ | |||
|
|
|||
There was a problem hiding this comment.
This is a copy of: https://github.com/noironetworks/acc-provision/blob/master/provision/acc_provision/templates/acc-provision-crd.yaml
and I would suggest that we do not create manual copies of files like this.
| To install | ||
| ----------- | ||
|
|
||
| helm install <helm-rel-name> aci-helm |
There was a problem hiding this comment.
aci-helm -> aci-cni (here and everywhere else we have used)
|
(didnt realize my inline comments had not gotten published) |
4 participants
this PR is for the task https://github.com/noironetworks/support/issues/1879.