v6.59-beta - #664
Merged
Merged
Conversation
Two features reached the test suite only indirectly: - /admin/drug/attributes-list, the entry point of the drug curation screen. Its query in drugs_repository.get_admin_drug_list joins the outlier counters with the schema attributes and the public substance catalog and exposes ~20 filters, none of which were exercised end-to-end (repository at 38% coverage). - The protocol tracing endpoints (/protocol/prescription-trace, /protocol/test/sample, /protocol/test). Only the internal _evaluate_date_groups helper had unit tests; the orchestration, applicability rules, name resolution and per-prescription error isolation had none (service at 33%). Both are covered with integration tests, since the behaviour under test lives in the SQL and in the route/service/repository wiring rather than in isolated logic. Coverage: drugs_repository 38% -> 90%, protocol_trace_service 33% -> 92%, routes/protocol 87% -> 97%. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CjEbprG7BvzEUsrkjttd1j
test: cover admin drug listing and protocol tracing
![amazon-q-developer[bot]](https://avatars.githubusercontent.com/in/1220912?s=60&v=4){kind=small}
There was a problem hiding this comment.
This PR includes a version bump to v6.59-beta, a bug fix for date/datetime handling in protocol alerts, and two comprehensive integration test suites. The changes are well-structured and don't introduce any blocking issues. The code is ready to merge.
You can now have the agent implement changes and create commits directly on your pull request's source branch. Simply comment with /q followed by your request in natural language to ask the agent to make changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.