PKG-473: Fix Docker mount race condition for ccache directory - #3
Open
nogueiraanderson wants to merge 1 commit into
Open
PKG-473: Fix Docker mount race condition for ccache directory#3nogueiraanderson wants to merge 1 commit into
nogueiraanderson wants to merge 1 commit into
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
nogueiraanderson
force-pushed
the
PKG-473-docker-mount-fix
branch
2 times, most recently
from
July 3, 2025 08:46
8dd5101 to
bd8ac11
Compare
Always creates .ccache directory before Docker mount to prevent build failures when directory doesn't exist: - Simple approach with minimal overhead - Maintains current Docker command structure - Fixes dependency assumption violation - Less risk than conditional mount logic Fixes build error: docker: Error response from daemon: invalid mount config for type "bind": bind source path does not exist: /path/to/.ccache
nogueiraanderson
force-pushed
the
PKG-473-docker-mount-fix
branch
from
July 3, 2025 08:53
bd8ac11 to
c165ca8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes Docker mount failure when .ccache directory doesn't exist.
Problem
Docker script assumes .ccache directory exists but dependency can be violated:
${env.WORKSPACE}/.ccache${ROOT_DIR}/.ccacheSolution
mkdir -p "${ROOT_DIR}/.ccache"