refactor(game): extract shared.ts (Phase 0 of #132)#135
Merged
Conversation
Move createBaseGameProperties, incrementStateVersion, and MAX_PIP_COUNT out of the Game class into src/Game/shared.ts as free functions. Call sites in index.ts now import them directly (Rule A: extracted functions never route through the Game facade). MAX_PIP_COUNT was dead in index.ts; it now has a shared home for downstream modules. No behavior change. Core: 448 passed / 12 skipped, tsc -b clean. Refs #132, #133
This was referenced Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase 0 of the Game/index.ts decomposition epic (#133)
First slice of splitting the 2491-line
Game/index.tsgod file (#132).What changed
src/Game/shared.ts(leaf module) holdscreateBaseGameProperties,incrementStateVersion, andMAX_PIP_COUNTas exported free functions/const.index.tsimports them directly and calls them as free functions — Rule A: extracted functions never route back through theGamefacade (avoids an index↔module cycle).private staticmethods (no external callers).MAX_PIP_COUNTwas dead code inindex.ts; it now has a shared home for later modules.Verification
tsc -b --forcecleannpx jest: 448 passed / 12 skipped (identical to baseline)Game.*surface untouched)Refs #132, #133