fix: make debug single-game simulator rule-compliant#130
Merged
Conversation
runDebugSingleGame picked the first legal move and broke on any Game.move error, so the must-use-both-dice / must-use-larger-die enforcement made it strand a die, throw, and loop to the turn limit (stuck=true). Gather candidates across all ready dice and skip rule-rejected moves, matching the EngineRunner driver.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #129. The smoke suite's
simulate-ten-gamestest failed withstuck: truebecauserunDebugSingleGame(a separate naive driver from EngineRunner) picked the first legal move andbreaked on anyGame.moveerror. With the new must-use-both-dice / must-use-larger-die enforcement, its greedy choice strands a die,Game.movethrows, and the turn never completes → loops to the 1000-turn limit.Fix: gather candidate (checker, die) pairs across all ready dice and try each, skipping moves the engine rejects for a rule violation — same pattern as the EngineRunner fix in #129. Verified 30/30 games complete with 0 stuck locally.