Repository navigation
Handle missing LTS schedule dates in lts-lint-definitions - #122
Merged
Merged
Conversation
Node's schedule.json now lists v27 without a "maintenance" date. Under `set -u`, the indirect expansion of the missing variable aborts the lint with "maint_date_var: unbound variable", failing every run. Default missing dates to empty, and treat an empty date as not yet past so release lines without a scheduled phase aren't flagged. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Node's
schedule.jsonnow includes av27entry with nomaintenancedate:lts-lint-definitionsruns underset -u, so${!maint_date_var}aborts with:This fails the
ltsjob on every node-build PR (e.g. nodenv/node-build#1143), and silently on the scheduled scrape since that step iscontinue-on-error.Fix
end/maintenancedates to empty (${!var-}).past()returns false for an empty date. Otherwise"" < TODAYis true and every v27 definition would be flagged as needing an LTS warning.Verified
Against node-build's
share/node-build(with #1143's definitions added):24.22.1, it reports that file and exits 1--fixre-inserts the warning🤖 Generated with Claude Code