ci: extend Windows Node.js workflow timeout#5426
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5426 +/- ##
=======================================
Coverage 93.35% 93.36%
=======================================
Files 110 110
Lines 36993 36993
=======================================
+ Hits 34535 34537 +2
+ Misses 2458 2456 -2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Increase the reusable Node.js workflow timeout from 20 to 30 minutes for Windows jobs only.
Motivation
Windows CI on
mainhas been getting cancelled while running WPT near the 20-minute job timeout. The WPT server shutdown lines in the logs are cleanup during cancellation, not a separate WPT assertion failure.Evidence from the first affected run (
0d6ecc571095, run27418354554):13:21:40.npm run test:wptstarted at13:30:42.13:41:40.13:41:40.13:41:42, right at the 20-minute job timeout boundary.This keeps the existing 20-minute timeout for non-Windows jobs and gives Windows enough budget to finish WPT and cleanup reliably.
Validation
git diff --check.github/workflows/nodejs.ymlwith the repositoryyamlpackagenpm run lint