Skip to content

ci: extend Windows Node.js workflow timeout#5426

Merged
mcollina merged 1 commit into
mainfrom
ci-increase-windows-wpt-timeout
Jun 15, 2026
Merged

ci: extend Windows Node.js workflow timeout#5426
mcollina merged 1 commit into
mainfrom
ci-increase-windows-wpt-timeout

Conversation

@mcollina

Copy link
Copy Markdown
Member

Summary

Increase the reusable Node.js workflow timeout from 20 to 30 minutes for Windows jobs only.

Motivation

Windows CI on main has been getting cancelled while running WPT near the 20-minute job timeout. The WPT server shutdown lines in the logs are cleanup during cancellation, not a separate WPT assertion failure.

Evidence from the first affected run (0d6ecc571095, run 27418354554):

  • Windows Node.js 22 job started at 13:21:40.
  • npm run test:wpt started at 13:30:42.
  • WPT was still running at 13:41:40.
  • WPT server cleanup logged at 13:41:40.
  • The job was cancelled at 13:41:42, right at the 20-minute job timeout boundary.

This keeps the existing 20-minute timeout for non-Windows jobs and gives Windows enough budget to finish WPT and cleanup reliably.

Validation

  • git diff --check
  • Parsed .github/workflows/nodejs.yml with the repository yaml package
  • Commit hook ran npm run lint

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.36%. Comparing base (363e44f) to head (1855b49).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5426   +/-   ##
=======================================
  Coverage   93.35%   93.36%           
=======================================
  Files         110      110           
  Lines       36993    36993           
=======================================
+ Hits        34535    34537    +2     
+ Misses       2458     2456    -2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mcollina mcollina merged commit f4045b9 into main Jun 15, 2026
38 checks passed
@mcollina mcollina deleted the ci-increase-windows-wpt-timeout branch June 15, 2026 09:51
@github-actions github-actions Bot mentioned this pull request Jun 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants