fix: Fixed tracePromise to handle returning result when function being wrapped is not a promise - #46
Merged
Conversation
…ing wrapped is not a promise
Qard
approved these changes
Mar 26, 2026
rochdev
approved these changes
Mar 26, 2026
This was referenced Mar 26, 2026
Merged
Closed
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@Qard observed
tracePromisewas incorrectly handling when the function being wrapped lacked a thenable. This PR fixes that. I also updated the preamble to return the result in the end event when it is applicable.