Skip to content

fix(pnpm): warn > error - #9051

Closed
avivkeller wants to merge 1 commit into
mainfrom
warn-over-error-pnpm-changesets
Closed

fix(pnpm): warn > error#9051
avivkeller wants to merge 1 commit into
mainfrom
warn-over-error-pnpm-changesets

Conversation

@avivkeller

Copy link
Copy Markdown
Member

Don't fail CI when Changesets uses npm publish.

cc @nodejs/web-infra fast-tracking

Signed-off-by: Aviv Keller <me@aviv.sh>
@avivkeller
avivkeller requested a review from a team as a code owner July 30, 2026 19:45
@avivkeller avivkeller added the fast-track Fast Tracking PRs label Jul 30, 2026
Copilot AI review requested due to automatic review settings July 30, 2026 19:45
@vercel

vercel Bot commented Jul 30, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
nodejs-org Ready Ready Preview Jul 30, 2026 7:46pm

Request Review

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@cursor

cursor Bot commented Jul 30, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
Single config tweak with no application or security impact; Node runtime devEngine remains strict.

Overview
devEngines.packageManager.onFail is changed from error to warn in root package.json.

Node still errors on runtime version mismatch; only enforcement when the active package manager does not match the declared pnpm version is relaxed. That avoids CI failures when Changesets runs npm publish, which does not use pnpm even though the repo pins pnpm via packageManager.

Reviewed by Cursor Bugbot for commit e90d66f. Bugbot is set up for automated code reviews on this repo. Configure here.

@avivkeller avivkeller changed the title fix(pnpm): warn > over fix(pnpm): warn > error Jul 30, 2026
@codecov

codecov Bot commented Jul 30, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.11%. Comparing base (0ab03a2) to head (e90d66f).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9051      +/-   ##
==========================================
- Coverage   75.13%   75.11%   -0.03%     
==========================================
  Files         102      102              
  Lines        9105     9105              
  Branches      372      372              
==========================================
- Hits         6841     6839       -2     
- Misses       2260     2262       +2     
  Partials        4        4              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@bjohansebas
bjohansebas enabled auto-merge July 30, 2026 19:48
@bjohansebas
bjohansebas disabled auto-merge July 30, 2026 19:50

@MattIPv4 MattIPv4 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has significant implications for the DX of folks working with this repo. Let's get changesets using the package manager we choose to use for this repo, rather than changing how we handle package managers for every interaction with the repo.

@github-actions

Copy link
Copy Markdown
Contributor

📦 Build Size Comparison

Summary

Metric Value
Old Total First Load JS 7.16 MB
New Total First Load JS 7.16 MB
Delta 0 B (0.00%)

@avivkeller avivkeller closed this Jul 30, 2026
@bjohansebas
bjohansebas deleted the warn-over-error-pnpm-changesets branch July 30, 2026 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fast-track Fast Tracking PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants