src: mark config file as stable

[marco-ippolito]

No description provided.

[nodejs-github-bot]

Review requested:

• @nodejs/config
• @nodejs/security-wg
• @nodejs/test_runner

[JakobJingleheimer]

I would love for this to get to stable (I one of my recent favourites in node), but I think we still have an important unresolved issue (that I admittedly haven't raised properly):

The schema(s) cite a specific node version, but that is not checked against the actual version of node running. So looking at the code, all looks well; and then it runs and 💥

This really reared its head with the recent breaking change of "testRunner" → "test" (which was also backported as a minor, breaking a stable line). I agree the change was good, but it broke the hell out of anyone using the config file for tests with no way to catch it.

[marco-ippolito]

I would love for this to get to stable (I one of my recent favourites in node), but I think we still have an important unresolved issue (that I admittedly haven't raised much):

The schema(s) cite a specific node version, but that is not checked against the actual version of node running. So looking at the code, all looks well; and then it runs and 💥

This really reared its head with the recent breaking change of "testRunner" → "test" (which was also backported as a minor, breaking a stable line). I agree the change was good, but it broke the hell out of anyone using the config file for tests with no way to catch it.

that's because it's an experimental feature, it made no sense to make the breaking change a semver major. it's trivial to add a check to match the version

[JakobJingleheimer]

that's because it's an experimental feature, it made no sense to make the breaking change a semver major.

For sure yes not a major; I would expect it on the current line (just not backported to a stable line).

it's trivial to add a check to match the version

Yeah, I'm suggesting we do that before marking this stable 🙂

[marco-ippolito]

Mind that this feature you are asking already partially xists:
https://nodejs.org/docs/latest/api/cli.html#--experimental-config-filepath---experimental-config-file

{
  "nodeVersion": 25,
  "nodeOptions": {
    "watch-path": "src"
  }
}

If you specify a nodeVersion it will be enforced

[JakobJingleheimer]

Mind that this feature you are asking already partially xists: https://github.com/nodejs/node/actions/runs/36847018850/job/110320230489?pr=66431

{
  "nodeVersion": 25,
  "nodeOptions": {
    "watch-path": "src"
  }
}

If you specify a nodeVersion it will be enforced

Ish. It wouldn't have addressed the above problem though because it's only major (and the break was in a minor); but maybe that's a non-issue once it becomes stable? 🤔

[mcollina]

lgtm

[marco-ippolito]

Ish. It wouldn't have addressed the above problem though because it's only major (and the break was in a minor); but maybe that's a non-issue once it becomes stable? 🤔

yes because it is stable across majors, at worse node has a more features thatn the config file but not breaking changes

[codecov]

Codecov Report

❌ Patch coverage is 97.61905% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 90.44%. Comparing base (f4d2742) to head (1c5fa78).

Files with missing lines	Patch %	Lines
src/node_config_file.cc	96.77%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #66431      +/-   ##
==========================================
+ Coverage   90.42%   90.44%   +0.01%     
==========================================
  Files         790      790              
  Lines      275435   275455      +20     
  Branches    52830    52829       -1     
==========================================
+ Hits       249075   249125      +50     
+ Misses      16768    16733      -35     
- Partials     9592     9597       +5     

Files with missing lines	Coverage Δ
lib/internal/bench_runner/cli.js	94.15% <100.00%> (+<0.01%)	⬆️
lib/internal/debugger/inspect_helpers.js	92.52% <100.00%> (+0.01%)	⬆️
lib/internal/process/pre_execution.js	96.50% <ø> (+0.08%)	⬆️
lib/internal/test_runner/runner.js	95.13% <100.00%> (+<0.01%)	⬆️
src/node_config_file.h	100.00% <ø> (ø)
src/node_options.cc	81.65% <100.00%> (+0.09%)	⬆️
src/node_options.h	95.65% <ø> (ø)
src/node_config_file.cc	84.41% <96.77%> (+0.73%)	⬆️

... and 25 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/78127/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/78135/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/78162/