sea: handle NUL bytes in asset keys - #64773
Open
Archkon wants to merge 1 commit into
Open
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
needs-ci
Construct the asset lookup string_view with the explicit Utf8Value length so embedded NUL bytes do not truncate keys. Signed-off-by: Archkon <180910180+Archkon@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #64773 +/- ##
==========================================
+ Coverage 90.14% 90.15% +0.01%
==========================================
Files 744 744
Lines 242518 242518
Branches 45685 45683 -2
==========================================
+ Hits 218611 218649 +38
+ Misses 15396 15364 -32
+ Partials 8511 8505 -6
🚀 New features to boost your workflow:
|
avivkeller
approved these changes
Jul 27, 2026
Contributor
Author
|
@avivkeller Could you apply request-ci for this ? |
avivkeller
added
author ready
avivkeller
reviewed
Aug 5, 2026
| return; | ||
| } | ||
| auto it = sea_resource.assets.find(*key); | ||
| auto it = sea_resource.assets.find(std::string_view(*key, key.length())); |
Member
There was a problem hiding this comment.
This transformation isn't going to hurt perf, right?
Just being cautious
github-actions
Bot
removed
the
request-ci
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Construct the asset lookup string_view with the explicit Utf8Value length so embedded NUL bytes do not truncate keys.