Skip to content

sea: avoid dangling CLI option pointers - #64755

Open
Archkon wants to merge 1 commit into
nodejs:mainfrom
Archkon:sea
Open

sea: avoid dangling CLI option pointers#64755
Archkon wants to merge 1 commit into
nodejs:mainfrom
Archkon:sea

Conversation

@Archkon

@Archkon Archkon commented Jul 26, 2026

Copy link
Copy Markdown
Contributor

Reserve exec argv storage before inserting configured and CLI-expanded arguments so vector reallocation cannot invalidate pointers in argv.

Reserve exec argv storage before inserting configured and CLI-expanded
arguments so vector reallocation cannot invalidate pointers in argv.

Signed-off-by: Archkon <180910180+Archkon@users.noreply.github.com>
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/single-executable

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. single-executable Issues and PRs related to single-executable applications labels Jul 26, 2026
@codecov

codecov Bot commented Jul 26, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.15%. Comparing base (4a5eb1c) to head (b043f5e).
⚠️ Report is 156 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #64755   +/-   ##
=======================================
  Coverage   90.15%   90.15%           
=======================================
  Files         744      744           
  Lines      242517   242517           
  Branches    45688    45693    +5     
=======================================
+ Hits       218642   218648    +6     
- Misses      15358    15360    +2     
+ Partials     8517     8509    -8     
Files with missing lines Coverage Δ
src/node_sea.cc 89.53% <100.00%> (ø)

... and 23 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Archkon

Archkon commented Aug 2, 2026

Copy link
Copy Markdown
Contributor Author

@avivkeller Could you apply request-ci for this ?

@Archkon

Archkon commented Aug 4, 2026

Copy link
Copy Markdown
Contributor Author

@anonrig @jasnell Could you apply request-ci fot this ?

@avivkeller avivkeller added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Aug 5, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 5, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. single-executable Issues and PRs related to single-executable applications

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants