Skip to content

src: close webstorage database on init failure - #64641

Open
Archkon wants to merge 1 commit into
nodejs:mainfrom
Archkon:webstorage
Open

src: close webstorage database on init failure#64641
Archkon wants to merge 1 commit into
nodejs:mainfrom
Archkon:webstorage

Conversation

@Archkon

@Archkon Archkon commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Fixes: #64640

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Jul 21, 2026
Signed-off-by: Archkon <180910180+Archkon@users.noreply.github.com>
@codecov

codecov Bot commented Jul 21, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.14%. Comparing base (00917ba) to head (71a70f1).
⚠️ Report is 273 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #64641      +/-   ##
==========================================
- Coverage   90.14%   90.14%   -0.01%     
==========================================
  Files         741      741              
  Lines      242076   242076              
  Branches    45558    45553       -5     
==========================================
- Hits       218216   218208       -8     
- Misses      15385    15391       +6     
- Partials     8475     8477       +2     
Files with missing lines Coverage Δ
src/node_webstorage.cc 74.93% <100.00%> (ø)

... and 31 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Archkon

Archkon commented Jul 28, 2026

Copy link
Copy Markdown
Contributor Author

ping @tniessen @cjihrig @targos Could you take a look at this ?

@Archkon

Archkon commented Aug 7, 2026

Copy link
Copy Markdown
Contributor Author

@jasnell Please take look at this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Web Storage Maybe leaks SQLite connections when database initialization fails

2 participants