http2: increase default window sizes by mcollina · Pull Request #64623 · nodejs/node

mcollina · 2026-07-20T12:33:00Z

Increase the default HTTP/2 stream window from 64KB (65535) to 4MB
(4194304) and the default local connection window to 32MB (33554432).

The default 64KB window limits throughput on high-latency connections
to window_size / RTT. With a 250ms RTT, throughput is limited to
256KB/s. The new defaults improve throughput to 16MB/s (128Mbps)
for the stream window and 128MB/s (1Gbps) for the connection window.

Fixes #38426

nodejs-github-bot · 2026-07-20T12:33:05Z

Review requested:

@nodejs/http
@nodejs/http2
@nodejs/net
@nodejs/sqlite

pimterry · 2026-07-20T13:07:12Z

+  // to window_size / RTT. With a 32MB connection window, throughput is
+  // significantly improved. See https://github.com/nodejs/node/issues/38426
+  CHECK_EQ(nghttp2_session_set_local_window_size(
+      session, NGHTTP2_FLAG_NONE, 0, 33554432), 0);


There's a pre-existing issue that this exposes: you can't configure this in advance. You can only control the connection window with session.setLocalWindowSize once you have a session, but at that point this initial WINDOW_UPDATE has already been sent, and shrinking the window isn't effective as shown in the tests here (it just blocks further updates, it can't reduce what's already been sent). The stream window is configurable in advance (it's a SETTINGS parameter) but this connection window isn't.

That already existed implicitly but it was kind of OK when the initial window was small, but it's a real problem with a very large initial window I think, since there's basically no way to override this to make it any smaller again if you need to.

Can we add client & server options for this, so it can be configured before the first WINDOW_UPDATE is sent somehow?

pimterry · 2026-07-20T13:55:24Z

+  // to window_size / RTT. With a 32MB connection window, throughput is
+  // significantly improved. See https://github.com/nodejs/node/issues/38426
+  CHECK_EQ(nghttp2_session_set_local_window_size(
+      session, NGHTTP2_FLAG_NONE, 0, 33554432), 0);


Nit: would be nicer to extract this as a constant

codecov · 2026-07-20T14:26:55Z

Codecov Report

❌ Patch coverage is 55.55556% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.16%. Comparing base (c8e2a82) to head (f399373).
⚠️ Report is 90 commits behind head on main.

Files with missing lines	Patch %	Lines
src/stream_pipe.cc	0.00%	4 Missing and 1 partial ⚠️
src/stream_base.cc	0.00%	0 Missing and 2 partials ⚠️
src/node_http2.cc	0.00%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #64623      +/-   ##
==========================================
- Coverage   90.16%   90.16%   -0.01%     
==========================================
  Files         746      746              
  Lines      242760   242773      +13     
  Branches    45765    45766       +1     
==========================================
+ Hits       218875   218885      +10     
+ Misses      15375    15368       -7     
- Partials     8510     8520      +10

Files with missing lines	Coverage Δ
lib/internal/http2/core.js	`95.07% <100.00%> (+0.01%)`	⬆️
src/node_http2.h	`92.26% <ø> (ø)`
src/node_http2.cc	`81.66% <0.00%> (-0.09%)`	⬇️
src/stream_base.cc	`79.74% <0.00%> (-0.30%)`	⬇️
src/stream_pipe.cc	`56.48% <0.00%> (-3.06%)`	⬇️

... and 31 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

mcollina · 2026-07-20T16:49:17Z

Both addressed:

Extracted DEFAULT_SETTINGS_LOCAL_CONNECTION_WINDOW_SIZE = 33554432 as a named constant in src/node_http2.h and used it in src/node_http2.cc.
The pre-existing issue about not being able to configure the connection window in advance is noted — the initial WINDOW_UPDATE is sent at session creation before setLocalWindowSize can be called. This is a known limitation of the current API.

RafaelGSS

Wouldn't it be semver-major PRs that contain breaking changes and should be released in the next major version. ?

mcollina · 2026-07-20T19:52:30Z

yes

pimterry · 2026-07-21T20:32:41Z

The pre-existing issue about not being able to configure the connection window in advance is noted — the initial WINDOW_UPDATE is sent at session creation before setLocalWindowSize can be called. This is a known limitation of the current API.

I do think this would be useful, but doesn't need to block this - I'll open a separate PR.

Ethan-Arrowood

CI failure seems related to the change here; test-http2-respond-with-file-connection-abort is failing across multiple systems and that isn't a known flake. Leaving a request changes to this gets fixed before landing.

Increase the default HTTP/2 stream window from 64KB (65535) to 4MB (4194304) and the default local connection window to 32MB (33554432). The default 64KB window limits throughput on high-latency connections to window_size / RTT. With a 250ms RTT, throughput is limited to 256KB/s. The new defaults improve throughput to 16MB/s (128Mbps) for the stream window and 128MB/s (1Gbps) for the connection window. Fixes: nodejs#38426 Signed-off-by: Matteo Collina <hello@matteocollina.com>

When a stream is destroyed while a synchronous write is in flight from StreamPipe::ProcessData, ReportWritesToJSStreamListener:: OnStreamAfterReqFinished can be called with a null stream_ or a null req_wrap, causing a null pointer dereference. This race becomes more likely with larger HTTP/2 windows (e.g., nodejs#38426) because more data is in flight during session teardown. Add early-return guards for both cases to prevent the crash. Refs: nodejs#38426 Refs: nodejs#56825 Signed-off-by: Matteo Collina <hello@matteocollina.com>

With the default window size increase, the server sends an additional WINDOW_UPDATE frame during session setup, increasing the frames received by the client from 7 to 8 on some platforms. Relax the assertion to check >= 7 instead of strict equality. Refs: nodejs#38426 Signed-off-by: Matteo Collina <hello@matteocollina.com>

When the writable sink is destroyed while there are still pending writes, WritableListener::OnStreamDestroy previously reset pending_writes_ to 0. This caused OnStreamAfterWrite to decrement the counter below 0, making the pending_writes_ == 0 completion check fail permanently — the oncomplete callback was never called, causing a timeout. Fix by: 1. Not resetting pending_writes_ in OnStreamDestroy — let OnStreamAfterWrite track completion naturally. 2. Using sink_destroyed_ flag in Unpipe to always remove the writable listener regardless of pending_writes_ count. 3. Using <= 0 (instead of == 0) when sink_destroyed_ is set, and guarding RemoveStreamListener against a null stream. This race became more likely with larger HTTP/2 windows (nodejs#38426) because more writes are in flight when session teardown begins. Refs: nodejs#38426 Refs: nodejs#56825 Signed-off-by: Matteo Collina <hello@matteocollina.com>

Signed-off-by: Matteo Collina <hello@matteocollina.com>

nodejs-github-bot · 2026-08-03T06:41:13Z

CI: https://ci.nodejs.org/job/node-test-pull-request/75413/

nodejs-github-bot · 2026-08-03T12:22:08Z

CI: https://ci.nodejs.org/job/node-test-pull-request/75428/

nodejs-github-bot · 2026-08-03T15:03:49Z

Commit Queue failed

- Loading data for nodejs/node/pull/64623 ✔ Done loading data for nodejs/node/pull/64623 ----------------------------------- PR info ------------------------------------ Title http2: increase default window sizes (#64623) Author Matteo Collina <matteo.collina@gmail.com> (@mcollina) Branch mcollina:increase-http2-window-size -> nodejs:main Labels c++, semver-major, lib / src Commits 5 - http2: increase default window sizes - http2: guard against null stream/req in OnStreamAfterReqFinished - http2: relax framesReceived assertion in perf_hooks test - stream: fix pending_writes underflow in StreamPipe shutdown - style: fix clang-format alignment in CHECK_EQ call Committers 1 - Matteo Collina <hello@matteocollina.com> PR-URL: https://github.com/nodejs/node/pull/64623 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Tim Perry <pimterry@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day> Reviewed-By: Ethan Arrowood <ethan@arrowood.dev> Reviewed-By: Aviv Keller <me@aviv.sh> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/64623 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Tim Perry <pimterry@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day> Reviewed-By: Ethan Arrowood <ethan@arrowood.dev> Reviewed-By: Aviv Keller <me@aviv.sh> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> -------------------------------------------------------------------------------- ℹ This PR was created on Mon, 20 Jul 2026 12:33:00 GMT ✔ Approvals: 8 ✔ - Rafael Gonzaga (@RafaelGSS) (TSC): https://github.com/nodejs/node/pull/64623#pullrequestreview-4737957628 ✔ - Tim Perry (@pimterry): https://github.com/nodejs/node/pull/64623#pullrequestreview-4765202215 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/64623#pullrequestreview-4749623762 ✔ - Gürgün Dayıoğlu (@gurgunday): https://github.com/nodejs/node/pull/64623#pullrequestreview-4765616109 ✔ - Ethan Arrowood (@Ethan-Arrowood): https://github.com/nodejs/node/pull/64623#pullrequestreview-4767534645 ✔ - Aviv Keller (@avivkeller): https://github.com/nodejs/node/pull/64623#pullrequestreview-4770440465 ✔ - Robert Nagy (@ronag) (TSC): https://github.com/nodejs/node/pull/64623#pullrequestreview-4838488304 ✔ - Trivikram Kamat (@trivikr): https://github.com/nodejs/node/pull/64623#pullrequestreview-4841424027 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2026-08-03T12:22:08Z: https://ci.nodejs.org/job/node-test-pull-request/75428/ - Querying data for job/node-test-pull-request/75428/ ✔ Build data downloaded ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 64623 From https://github.com/nodejs/node * branch refs/pull/64623/merge -> FETCH_HEAD ✔ Fetched commits as 7e439828de88..f3993733daf8 -------------------------------------------------------------------------------- Auto-merging doc/api/http2.md [main d458cadee7] http2: increase default window sizes Author: Matteo Collina <hello@matteocollina.com> Date: Mon Jul 20 12:09:08 2026 +0000 16 files changed, 78 insertions(+), 61 deletions(-) [main 2e28518bd9] http2: guard against null stream/req in OnStreamAfterReqFinished Author: Matteo Collina <hello@matteocollina.com> Date: Thu Jul 23 14:28:24 2026 +0000 1 file changed, 2 insertions(+) [main 8974b46a94] http2: relax framesReceived assertion in perf_hooks test Author: Matteo Collina <hello@matteocollina.com> Date: Fri Jul 24 08:19:42 2026 +0000 1 file changed, 5 insertions(+), 1 deletion(-) [main 83d3ac6cb0] stream: fix pending_writes underflow in StreamPipe shutdown Author: Matteo Collina <hello@matteocollina.com> Date: Fri Jul 24 11:03:27 2026 +0000 1 file changed, 13 insertions(+), 4 deletions(-) [main 93ebe33adb] style: fix clang-format alignment in CHECK_EQ call Author: Matteo Collina <hello@matteocollina.com> Date: Fri Jul 24 15:10:46 2026 +0000 1 file changed, 3 insertions(+), 5 deletions(-) ✔ Patches applied There are 5 commits in the PR. Attempting autorebase. (node:365) [DEP0190] DeprecationWarning: Passing args to a child process with shell option true can lead to security vulnerabilities, as the arguments are not escaped, only concatenated. (Use `node --trace-deprecation ...` to show where the warning was created) Rebasing (2/10) Executing: git node land --amend --yes --------------------------------- New Message ---------------------------------- http2: increase default window sizes

Increase the default HTTP/2 stream window from 64KB (65535) to 4MB
(4194304) and the default local connection window to 32MB (33554432).

The default 64KB window limits throughput on high-latency connections
to window_size / RTT. With a 250ms RTT, throughput is limited to
256KB/s. The new defaults improve throughput to 16MB/s (128Mbps)
for the stream window and 128MB/s (1Gbps) for the connection window.

Fixes: #38426
Signed-off-by: Matteo Collina <hello@matteocollina.com>
PR-URL: #64623
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
Reviewed-By: Aviv Keller <me@aviv.sh>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

[detached HEAD 221808bb0e] http2: increase default window sizes
Author: Matteo Collina <hello@matteocollina.com>
Date: Mon Jul 20 12:09:08 2026 +0000
16 files changed, 78 insertions(+), 61 deletions(-)
Rebasing (3/10)
Rebasing (4/10)
Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
http2: guard against null stream/req in OnStreamAfterReqFinished

When a stream is destroyed while a synchronous write is in flight
from StreamPipe::ProcessData, ReportWritesToJSStreamListener::
OnStreamAfterReqFinished can be called with a null stream_ or a
null req_wrap, causing a null pointer dereference. This race
becomes more likely with larger HTTP/2 windows (e.g., #38426)
because more data is in flight during session teardown.

Add early-return guards for both cases to prevent the crash.

Refs: #38426
Refs: #56825
Signed-off-by: Matteo Collina <hello@matteocollina.com>
PR-URL: #64623
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
Reviewed-By: Aviv Keller <me@aviv.sh>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

[detached HEAD 83b091065d] http2: guard against null stream/req in OnStreamAfterReqFinished
Author: Matteo Collina <hello@matteocollina.com>
Date: Thu Jul 23 14:28:24 2026 +0000
1 file changed, 2 insertions(+)
Rebasing (5/10)
Rebasing (6/10)
Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
http2: relax framesReceived assertion in perf_hooks test

With the default window size increase, the server sends an additional
WINDOW_UPDATE frame during session setup, increasing the frames received
by the client from 7 to 8 on some platforms. Relax the assertion to
check >= 7 instead of strict equality.

Refs: #38426
Signed-off-by: Matteo Collina <hello@matteocollina.com>
PR-URL: #64623
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
Reviewed-By: Aviv Keller <me@aviv.sh>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

[detached HEAD 4a7c271e8b] http2: relax framesReceived assertion in perf_hooks test
Author: Matteo Collina <hello@matteocollina.com>
Date: Fri Jul 24 08:19:42 2026 +0000
1 file changed, 5 insertions(+), 1 deletion(-)
Rebasing (7/10)
Rebasing (8/10)
Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
stream: fix pending_writes underflow in StreamPipe shutdown

When the writable sink is destroyed while there are still pending
writes, WritableListener::OnStreamDestroy previously reset
pending_writes_ to 0. This caused OnStreamAfterWrite to decrement
the counter below 0, making the pending_writes_ == 0 completion
check fail permanently — the oncomplete callback was never called,
causing a timeout.

Fix by:

Not resetting pending_writes_ in OnStreamDestroy — let
OnStreamAfterWrite track completion naturally.
Using sink_destroyed_ flag in Unpipe to always remove the
writable listener regardless of pending_writes_ count.
Using <= 0 (instead of == 0) when sink_destroyed_ is set,
and guarding RemoveStreamListener against a null stream.

This race became more likely with larger HTTP/2 windows (#38426)
because more writes are in flight when session teardown begins.

Refs: #38426
Refs: #56825
Signed-off-by: Matteo Collina <hello@matteocollina.com>
PR-URL: #64623
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
Reviewed-By: Aviv Keller <me@aviv.sh>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

[detached HEAD 9d0e7f3fd7] stream: fix pending_writes underflow in StreamPipe shutdown
Author: Matteo Collina <hello@matteocollina.com>
Date: Fri Jul 24 11:03:27 2026 +0000
1 file changed, 13 insertions(+), 4 deletions(-)
Rebasing (9/10)
Rebasing (10/10)
Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
style: fix clang-format alignment in CHECK_EQ call

Signed-off-by: Matteo Collina <hello@matteocollina.com>
PR-URL: #64623
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
Reviewed-By: Aviv Keller <me@aviv.sh>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

[detached HEAD 6cbbcc670b] style: fix clang-format alignment in CHECK_EQ call
Author: Matteo Collina <hello@matteocollina.com>
Date: Fri Jul 24 15:10:46 2026 +0000
1 file changed, 3 insertions(+), 5 deletions(-)
Successfully rebased and updated refs/heads/main.

ℹ Add commit-queue-squash label to land the PR as one commit, or commit-queue-rebase to land as separate commits.

https://github.com/nodejs/node/actions/runs/30825144898

trivikr · 2026-08-03T15:13:26Z

@mcollina This either needs commit-queue-squash or commit-queue-rebase

nodejs-github-bot · 2026-08-04T14:01:35Z

Landed in 1576cb8

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Jul 20, 2026

mcollina requested review from pimterry, ronag and trivikr and removed request for pimterry July 20, 2026 12:33

pimterry reviewed Jul 20, 2026

View reviewed changes

mcollina force-pushed the increase-http2-window-size branch 2 times, most recently from 5c9bc03 to 4351b51 Compare July 20, 2026 16:48

mcollina force-pushed the increase-http2-window-size branch from 4351b51 to 31761a0 Compare July 20, 2026 18:25

RafaelGSS approved these changes Jul 20, 2026

View reviewed changes

mcollina added the semver-major PRs that contain breaking changes and should be released in the next major version. label Jul 20, 2026

mcollina force-pushed the increase-http2-window-size branch 3 times, most recently from 70882db to bd4cbd3 Compare July 21, 2026 16:44

bjohansebas approved these changes Jul 21, 2026

View reviewed changes

pimterry approved these changes Jul 21, 2026

View reviewed changes

metcoder95 approved these changes Jul 21, 2026

View reviewed changes

mcollina force-pushed the increase-http2-window-size branch from bd4cbd3 to 86b969b Compare July 21, 2026 22:16

jasnell approved these changes Jul 21, 2026

View reviewed changes

mcollina force-pushed the increase-http2-window-size branch from 86b969b to d0c68ba Compare July 22, 2026 09:39

gurgunday approved these changes Jul 22, 2026

View reviewed changes

Ethan-Arrowood requested changes Jul 23, 2026

View reviewed changes

mcollina force-pushed the increase-http2-window-size branch from 481f180 to a25a676 Compare July 27, 2026 08:07

This comment was marked as outdated.

Sign in to view

mcollina added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 29, 2026

mcollina added 5 commits July 30, 2026 21:17

style: fix clang-format alignment in CHECK_EQ call

f399373

Signed-off-by: Matteo Collina <hello@matteocollina.com>

mcollina force-pushed the increase-http2-window-size branch from a25a676 to f399373 Compare July 30, 2026 21:20

ronag approved these changes Aug 2, 2026

View reviewed changes

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 2, 2026

This comment was marked as outdated.

Sign in to view

trivikr approved these changes Aug 3, 2026

View reviewed changes

mcollina added commit-queue Add this label to land a pull request using GitHub Actions. and removed needs-ci PRs that need a full CI run. labels Aug 3, 2026

nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Aug 3, 2026

trivikr removed the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Aug 3, 2026

mcollina added commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. commit-queue Add this label to land a pull request using GitHub Actions. labels Aug 3, 2026

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 3, 2026

aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 4, 2026

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 4, 2026

nodejs-github-bot merged commit 1576cb8 into nodejs:main Aug 4, 2026
82 checks passed

Uh oh!

Uh oh!

Conversation

mcollina commented Jul 20, 2026

Uh oh!

nodejs-github-bot commented Jul 20, 2026

Uh oh!

pimterry Jul 20, 2026

Choose a reason for hiding this comment

Uh oh!

pimterry Jul 20, 2026

Choose a reason for hiding this comment

Uh oh!

codecov Bot commented Jul 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

mcollina commented Jul 20, 2026

Uh oh!

RafaelGSS left a comment

Choose a reason for hiding this comment

Uh oh!

mcollina commented Jul 20, 2026

Uh oh!

pimterry commented Jul 21, 2026

Uh oh!

Ethan-Arrowood left a comment

Choose a reason for hiding this comment

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

nodejs-github-bot commented Aug 3, 2026

Uh oh!

nodejs-github-bot commented Aug 3, 2026

Uh oh!

nodejs-github-bot commented Aug 3, 2026

[detached HEAD 6cbbcc670b] style: fix clang-format alignment in CHECK_EQ call Author: Matteo Collina <hello@matteocollina.com> Date: Fri Jul 24 15:10:46 2026 +0000 1 file changed, 3 insertions(+), 5 deletions(-) Successfully rebased and updated refs/heads/main.

Uh oh!

trivikr commented Aug 3, 2026

Uh oh!

Uh oh!

nodejs-github-bot commented Aug 4, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

13 participants

codecov Bot commented Jul 20, 2026 •

edited

Loading

[detached HEAD 6cbbcc670b] style: fix clang-format alignment in CHECK_EQ call
Author: Matteo Collina <hello@matteocollina.com>
Date: Fri Jul 24 15:10:46 2026 +0000
1 file changed, 3 insertions(+), 5 deletions(-)
Successfully rebased and updated refs/heads/main.