Skip to content

zlib: restore unzip auto-detection on reset - #64620

Open
Archkon wants to merge 1 commit into
nodejs:mainfrom
Archkon:zlib4
Open

zlib: restore unzip auto-detection on reset#64620
Archkon wants to merge 1 commit into
nodejs:mainfrom
Archkon:zlib4

Conversation

@Archkon

@Archkon Archkon commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Fixes: #64619

Restore the initial UNZIP mode and clear partial gzip header state when
resetting an Unzip stream. Preserve GUNZIP mode for internal resets
between concatenated gzip members.

Signed-off-by: Archkon <180910180+Archkon@users.noreply.github.com>
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. zlib Issues and PRs related to the zlib subsystem. labels Jul 20, 2026
@codecov

codecov Bot commented Jul 20, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.15%. Comparing base (00917ba) to head (0d4ae13).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #64620      +/-   ##
==========================================
+ Coverage   90.14%   90.15%   +0.01%     
==========================================
  Files         741      741              
  Lines      242076   242084       +8     
  Branches    45558    45558              
==========================================
+ Hits       218216   218250      +34     
+ Misses      15385    15357      -28     
- Partials     8475     8477       +2     
Files with missing lines Coverage Δ
src/node_zlib.cc 78.29% <100.00%> (-0.21%) ⬇️

... and 19 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Archkon

Archkon commented Jul 28, 2026

Copy link
Copy Markdown
Contributor Author

ping @addaleax Could you take a look at this ?

@Archkon

Archkon commented Aug 7, 2026

Copy link
Copy Markdown
Contributor Author

@jasnell Please take a look at this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. zlib Issues and PRs related to the zlib subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

zlib: createUnzip().reset() does not restore auto-detection state

2 participants