Fix unref timer parent #64490 - #64491
Open
Shivay-98 wants to merge 2 commits into
Open
Conversation
Signed-off-by: Shivay-98 <shivay8306@gmail.com>
Collaborator
|
Review requested:
|
nodejs-github-bot
added
http2
Contributor
|
Can you remove the additional commit and fix the failing test? Also, the commit should have the |
This comment was marked as low quality.
This comment was marked as low quality.
marco1991layker-code
left a comment
marco1991layker-code
left a comment
There was a problem hiding this comment.
Each property is an array containing all values received for that header.
3 tasks
haggholm
pushed a commit
to hightouchio/node
that referenced
this pull request
Jul 21, 2026
The fix and approach are from nodejs#64491 by Shivay-98; this reopens it to get it landed, since the original stalled awaiting requested changes. `Socket.prototype._unrefTimer` and `Socket.prototype._destroy` both walk the `_parent` chain with a strict `!== null` check. During connection teardown a socket's `_parent` can be left `undefined` (for example a TLS socket layered over another stream), so the loop steps onto `undefined` and reads a property off it, throwing a TypeError: Cannot read properties of undefined (reading 'Symbol(timeout)') from an uncaught I/O callback and crashing the process. Using a nullish (`!= null`) check terminates the walk on both `null` and `undefined`. [petter@hightouch.io: apply the same fix to the identical loop in `_destroy`, which the original regression test already exercised via `destroy()`; add direct unit coverage for both paths.] Fixes: nodejs#64490 Refs: nodejs#64491 Signed-off-by: Petter Häggholm <petter@hightouch.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Socket.prototype._unrefTimer()traverses the_parentchain usingfor (let s = this; s !== null; s = s._parent).If
_parentbecomesundefined, the loop performs one additionaliteration and attempts to access
undefined[kTimeout], resulting in:TypeError: Cannot read properties of undefined (reading 'Symbol(timeout)')
Replace the strict
nullcheck with a nullish check (s != null) sothe traversal terminates for both
nullandundefined.A regression test has been added to cover this case.
Fixes: #64490