Skip to content

debugger: wait for target startup before initialization - #64304

Open
Archkon wants to merge 3 commits into
nodejs:mainfrom
Archkon:fixtest
Open

debugger: wait for target startup before initialization#64304
Archkon wants to merge 3 commits into
nodejs:mainfrom
Archkon:fixtest

Conversation

@Archkon

@Archkon Archkon commented Jul 5, 2026

Copy link
Copy Markdown
Contributor

Trying to fix the test error that triggered at previous pr when run github action ci/cd

https://github.com/nodejs/node/actions/runs/28730483133/job/85195106458?pr=64301

@nodejs-github-bot nodejs-github-bot added debugger Issues and PRs related to the debugger subsystem. needs-ci PRs that need a full CI run. labels Jul 5, 2026
@trivikr

trivikr commented Jul 5, 2026

Copy link
Copy Markdown
Member

Several previous attempts of deflaking were unsuccessful.
Please refer #64116 for prior discussions and links to other PRs.

@Archkon

Archkon commented Jul 5, 2026

Copy link
Copy Markdown
Contributor Author

Several previous attempts of deflaking were unsuccessful. Please refer #64116 for prior discussions and links to other PRs.

Ok, I got it .Thanks !

@Archkon
Archkon marked this pull request as draft July 6, 2026 05:26
@Archkon
Archkon force-pushed the fixtest branch 2 times, most recently from 1b28a3e to 88fe3e7 Compare July 29, 2026 23:45
Archkon added 2 commits July 30, 2026 07:47
Signed-off-by: Archkon <180910180+Archkon@users.noreply.github.com>
Signed-off-by: Archkon <180910180+Archkon@users.noreply.github.com>
@Archkon Archkon changed the title debugger: defer pause to avoid pause forever debugger: wait for target startup before initialization Jul 29, 2026
@Archkon
Archkon marked this pull request as ready for review July 29, 2026 23:58
@codecov

codecov Bot commented Jul 30, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 96.49123% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.14%. Comparing base (e7904d4) to head (28953e2).

Files with missing lines Patch % Lines
lib/internal/debugger/inspect_helpers.js 95.23% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #64304      +/-   ##
==========================================
- Coverage   90.14%   90.14%   -0.01%     
==========================================
  Files         746      746              
  Lines      242764   242819      +55     
  Branches    45739    45754      +15     
==========================================
+ Hits       218848   218895      +47     
+ Misses      15426    15425       -1     
- Partials     8490     8499       +9     
Files with missing lines Coverage Δ
lib/internal/debugger/inspect_probe.js 82.14% <100.00%> (+<0.01%) ⬆️
lib/internal/debugger/inspect_repl.js 91.36% <100.00%> (+0.05%) ⬆️
lib/internal/debugger/inspect_helpers.js 97.00% <95.23%> (-0.41%) ⬇️

... and 19 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Archkon

Archkon commented Jul 30, 2026

Copy link
Copy Markdown
Contributor Author

@joyeecheung @trivikr Could you take a look at this? I believe this would fix the flaky tests that related to timou of macos ci

Signed-off-by: Archkon <180910180+Archkon@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

debugger Issues and PRs related to the debugger subsystem. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants