Skip to content

doc: clarify that ipv4 mapped to ipv6 are classified as ipv6 - #62117

Open
gamemaker1 wants to merge 1 commit into
nodejs:mainfrom
gamemaker1:docs-net-ipv4-mapped-v6
Open

doc: clarify that ipv4 mapped to ipv6 are classified as ipv6#62117
gamemaker1 wants to merge 1 commit into
nodejs:mainfrom
gamemaker1:docs-net-ipv4-mapped-v6

Conversation

@gamemaker1

Copy link
Copy Markdown

Hi,

This PR adds a note and examples to the documentation of the isIP and isIPv6 methods, informing the reader that IPv4 addresses mapped to IPv6 are classified as IPv6.

This is not related to an existing issue, as far as I could find. I am opening this PR in the context of GHSA-46wh-pxpv-q5gq.

Please let me know if I have made any mistake, or if this change is not something that you want to merge.

Thanks!

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/net

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. net Issues and PRs related to the net subsystem. labels Mar 5, 2026

@Ethan-Arrowood Ethan-Arrowood left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@trivikr

trivikr commented Jul 21, 2026

Copy link
Copy Markdown
Member

@gamemaker1 Please amend the commit message to start with doc:

An example would be:

doc: clarify IPv4-mapped IPv6 classification

Also sign the commit message as per instructions

Your commit must contain the Signed-off-by line with your name and email address as an acknowledgement that you agree to the Developer Certificate of Origin.

Signed-off-by: Vedant Kulkarni <gamemaker0042@gmail.com>
@gamemaker1
gamemaker1 force-pushed the docs-net-ipv4-mapped-v6 branch from 38cff7e to 80ae991 Compare July 25, 2026 17:52
@gamemaker1

Copy link
Copy Markdown
Author

Done, sorry for missing that.

@gamemaker1 gamemaker1 changed the title net: add note about ipv4 mapped to ipv6 being classified as ipv6 doc: clarify that ipv4 mapped to ipv6 are classified as ipv6 Jul 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc Issues and PRs related to the documentations. net Issues and PRs related to the net subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants