fix(jsx-ast): hide redundant headers and badges for overloaded methods - #1038
Open
moshams272 wants to merge 2 commits into
Open
fix(jsx-ast): hide redundant headers and badges for overloaded methods#1038moshams272 wants to merge 2 commits into
moshams272 wants to merge 2 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1038 +/- ##
==========================================
+ Coverage 89.37% 89.43% +0.06%
==========================================
Files 203 203
Lines 18986 19023 +37
Branches 1769 1779 +10
==========================================
+ Hits 16968 17013 +45
+ Misses 2011 2004 -7
+ Partials 7 6 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Member
|
cc @nodejs/web thoughts? |
Member
|
when you have long type table for the constructor the overlaod table seem alone |
Contributor
Author
What if we make a Nested ToC like we keep the output of that PR, but make the codeblock, that contains its signature, has an anchor id, and put it under the main one with its signature in the ToC. Something like that: - factorizeModule
- factorizeModule(options, callback): void
...But it'll not be good in ToC, WDUT?! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the heading from the overloads function; just keep one for the first function that appears like grouping them.
Validation
Before:
After:
Related Issues
None
Check List
pnpm testand all tests passed.pnpm run format:check&pnpm run lint.