Skip to content

Improve scanner reliability and built-in rule handlin - #2

Merged
nobuo-miura merged 1 commit into
mainfrom
1-improve-scanner-reliability-and-built-in-rule-handling
Jul 18, 2026
Merged

Improve scanner reliability and built-in rule handlin#2
nobuo-miura merged 1 commit into
mainfrom
1-improve-scanner-reliability-and-built-in-rule-handling

Conversation

@nobuo-miura

Copy link
Copy Markdown
Owner

Summary

Improve SecretLens reliability across rule loading, Docker images, CI logs, live verification, exclusions, baselines, and output handling.

Problems

  • Built-in rules were unavailable when the binary was installed with go install.
  • Docker layer parsing could silently miss secrets or ignore errors.
  • GitHub Actions logs were fetched through an incorrect API endpoint.
  • Live verification used masked values and inferred providers from rule IDs.
  • Glob exclusions such as **/testdata/** did not work consistently.
  • Git and environment-file results could be duplicated.
  • Text output did not respect --out.
  • Invalid flag values were silently accepted.
  • Baseline updates were not implemented.
  • Organization scans used shallow clones and exposed tokens through clone URLs.

Changes

  • Embed built-in YAML rules in the binary.
  • Support additional and overriding rules through --rules-dir.
  • Stream Docker layers and propagate parsing errors.
  • Support legacy and OCI image layouts.
  • Use the repository workflow-runs API for GitHub Actions logs.
  • Restrict live verification to explicitly configured providers.
  • Remove unsupported GCP API-key verification.
  • Clear raw secret values before reporting.
  • Add proper ** glob support.
  • Deduplicate findings and stabilize fingerprints across line changes.
  • Implement baseline updates.
  • Validate source, format, severity, and custom-rule definitions.
  • Respect --out for text reports.
  • Use full-history organization clones without placing tokens in URLs.
  • Add tests for Docker parsing, glob exclusions, and rule validation.

@nobuo-miura nobuo-miura self-assigned this Jul 18, 2026
@nobuo-miura nobuo-miura linked an issue Jul 18, 2026 that may be closed by this pull request
@nobuo-miura
nobuo-miura merged commit f254d97 into main Jul 18, 2026
1 check passed
@nobuo-miura
nobuo-miura deleted the 1-improve-scanner-reliability-and-built-in-rule-handling branch July 18, 2026 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve scanner reliability and built-in rule handling

1 participant