Add stop-time option to App Extension, to stop container after wanted number of seconds - #22
Closed
noaOrMlnx wants to merge 1 commit into
Closed
Add stop-time option to App Extension, to stop container after wanted number of seconds#22noaOrMlnx wants to merge 1 commit into
noaOrMlnx wants to merge 1 commit into
Conversation
DavidZagury
reviewed
Mar 24, 2026
| 'docker_image_run_opt': run_opt, | ||
| 'sonic_asic_platform': sonic_asic_platform | ||
| 'sonic_asic_platform': sonic_asic_platform, | ||
| 'stop_time': stop_time |
There was a problem hiding this comment.
Have you made sure what happens when installing app extensions that does not have this new value?
Owner
Author
There was a problem hiding this comment.
please check the changes I've made in manifest.py - the default value of stop-time is ''.
DavidZagury
approved these changes
Mar 24, 2026
… number of seconds Signed-off-by: noaOrMlnx <noaor@nvidia.com>
noaOrMlnx
force-pushed
the
app-ext-stop-time
branch
from
March 24, 2026 19:58
38e5704 to
2fc0635
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Add stop-time to manifest options, and pass the stop-time to docker_image_ctl.j2.
+
sonic-buildimage PR
How to verify it
Run Application extension with stop-time in manifest and make sure it is stopping after the wanted stop-time.
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)