Add stop-time to docker_image_ctl.j2 to define the container stop time - #74
Closed
noaOrMlnx wants to merge 1 commit into
Closed
Add stop-time to docker_image_ctl.j2 to define the container stop time#74noaOrMlnx wants to merge 1 commit into
noaOrMlnx wants to merge 1 commit into
Conversation
DavidZagury
approved these changes
Mar 24, 2026
Signed-off-by: noaOrMlnx <noaor@nvidia.com>
noaOrMlnx
force-pushed
the
app-ext-stop-time
branch
from
March 24, 2026 19:58
ed662a1 to
060ca2b
Compare
noaOrMlnx
pushed a commit
that referenced
this pull request
Jul 27, 2026
…sonic-net#28349) #### Why I did it src/dhcpmon ``` * 1f3f4f9 - (HEAD -> master, origin/master, origin/HEAD) [dhcp_devman] Ignore duplicate -i* arguments instead of crashing/leaking (#76) (13 hours ago) [Xichen96] * 2883fe8 - [dhcpmon] Log Relay-Forward / Relay-Reply counters in v6 status (#75) (13 hours ago) [Xichen96] * 892925b - [dhcpmon] Cleanup stale v6 counters from COUNTERS_DB (#74) (16 hours ago) [Xichen96] ``` #### How I did it #### How to verify it #### Description for the changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
For Application Extensions to have the option to stop the container after X number of seconds, and not the default.
How I did it
Update docker_image_ctl.j2 to read the J2 parameter value and call docker stop -t <stop_time>.
+
sonic-utilities PR.
How to verify it
Run Application extension with stop-time in manifest and make sure it is stopping after the wanted stop-time.
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)