Skip to content

Fix/null date format #202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
abi-muller merged 2 commits into from
Jun 9, 2026
Merged

Fix/null date format #202

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e85eb9e
dont format a date that doesnt exist
abi-muller Jun 9, 2026
3b22bfa
8.1.1
abi-muller Jun 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions backend/api/application/services/data_service.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -345,13 +345,11 @@ def _enrich_columns(
for column in schema.columns:
statistics = None
if column in date_columns:
max_value = statistics_dataframe.at[0, f"max_{column.name}"]
min_value = statistics_dataframe.at[0, f"min_{column.name}"]
statistics = {
"max": statistics_dataframe.at[0, f"max_{column.name}"].strftime(
strftime_format
),
"min": statistics_dataframe.at[0, f"min_{column.name}"].strftime(
strftime_format
),
"max": None if pd.isna(max_value) else max_value.strftime(strftime_format),
"min": None if pd.isna(min_value) else min_value.strftime(strftime_format),
}
enriched_columns.append(
EnrichedColumn(**column.model_dump(), statistics=statistics)
Expand Down
2 changes: 1 addition & 1 deletion backend/api/domain/enriched_schema.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@


class EnrichedColumn(Column):
statistics: Optional[Dict[str, str]] = None
statistics: Optional[Dict[str, Optional[str]]] = None


class EnrichedSchemaMetadata(SchemaMetadata):
Expand Down
10 changes: 10 additions & 0 deletions docs/changelog/api.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,15 @@
# API Changelog

## v8.1.1 - _2026-06-09_

See [v8.1.1] changes

### Features

- Fixed bug formating dates if they are null

[v8.1.1]: https://github.com/no10ds/rapid/compare/v8.1.0...v8.1.1

## v8.1.0 - _2026-06-04_

See [v8.1.0] changes
Expand Down
4 changes: 2 additions & 2 deletions infrastructure/modules/rapid/variables.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,13 +13,13 @@ variable "app-replica-count-max" {
variable "application_version" {
type = string
description = "The version number for the application image (e.g.: v1.0.4, v1.0.x-latest, etc.)"
default = "v8.1.0"
default = "v8.1.1"
}

variable "ui_version" {
type = string
description = "The version number for the static ui (e.g.: v1.0.0, etc.)"
default = "v8.1.0"
default = "v8.1.1"
}

variable "catalog_disabled" {
Expand Down
Loading