Feature/upgrade storybook#155
Merged
Merged
Conversation
MotwaniM
requested changes
Feb 4, 2026
| <Head> | ||
| <meta name="emotion-insertion-point" content="" /> | ||
| <meta name="theme-color" content={theme.palette.primary.main} /> | ||
| <meta name="emotion-insertion-point" content="" /> |
Contributor
There was a problem hiding this comment.
is there a reason this is a duplicated meta tag?
Contributor
Author
There was a problem hiding this comment.
good spot thank you!
| data-emotion={`${style.key} ${style.ids.join(' ')}`} | ||
| key={style.key} | ||
| // eslint-disable-next-line react/no-danger | ||
| dangerouslySetInnerHTML={{ __html: style.css }} |
Contributor
There was a problem hiding this comment.
presume we're ok with this risk? We're opening ourselves to XSS attacks here
Contributor
Author
There was a problem hiding this comment.
think this is ok because the css is generated from our style components not user input
| ) | ||
| ] | ||
|
|
||
| export const initialGlobals = { |
Contributor
Author
There was a problem hiding this comment.
this sets the background option https://storybook.js.org/docs/essentials/toolbars-and-globals?renderer=vue#global-types-and-the-toolbar-annotation
abi-muller
changed the base branch from
feature/review_python_and_npm_dependencies
to
release/web-security
February 5, 2026 13:28
MotwaniM
self-requested a review
February 5, 2026 13:29
MotwaniM
approved these changes
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.