Fixed themes for legibility and to actually use the correct colors fo… - #22
Open
osunick wants to merge 1 commit into
Open
Fixed themes for legibility and to actually use the correct colors fo…#22osunick wants to merge 1 commit into
osunick wants to merge 1 commit into
Conversation
…r light and dark themes for dates
nmullaney
approved these changes
May 15, 2026
nmullaney
left a comment
nmullaney
left a comment
Owner
There was a problem hiding this comment.
Color changes look fine. Try not to include unrelated big changes with UI fixes next time.
| agp = "8.13.2" | ||
| agp = "9.1.1" | ||
| hiltCompiler = "2.57" | ||
| kotlin = "2.1.0" |
Owner
There was a problem hiding this comment.
These are pretty big lib changes, why did you add them in with a color change?
Normally, I'd ask for more testing, but i believe you've already pushed to production, so 🤷♀️
Collaborator
Author
|
oh that was because android studio put a button telling me to do it and I
just clicked it.
…On Fri, May 15, 2026 at 1:24 PM Nora ***@***.***> wrote:
***@***.**** approved this pull request.
Color changes look fine. Try not to include unrelated big changes with UI
fixes next time.
------------------------------
In gradle/libs.versions.toml
<#22 (comment)>
:
> hiltCompiler = "2.57"
-kotlin = "2.1.0"
These are pretty big lib changes, why did you add them in with a color
change?
Normally, I'd ask for more testing, but i believe you've already pushed to
production, so 🤷♀️
—
Reply to this email directly, view it on GitHub
<#22 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAD72K6DHXDMY4U3JXQLR3L4254GTAVCNFSM6AAAAACYZL66WCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHM2DGMBRGE2TMOBYHE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…r light and dark themes for dates